This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: RFC: xencomm in common

To: Tristan Gingold <Tristan.Gingold@xxxxxxxx>
Subject: [Xen-devel] Re: RFC: xencomm in common
From: Horms <horms@xxxxxxxxxxxx>
Date: Wed, 23 Aug 2006 17:28:49 +0900 (JST)
Cc: xen-ppc-devel@xxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Hollis Blanchard <hollisb@xxxxxxxxxx>, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 23 Aug 2006 02:13:25 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200608231015.41202.Tristan.Gingold@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: tin/1.8.2-20060425 ("Shillay") (UNIX) (Linux/2.6.17-2-686 (i686))
On Wed, 23 Aug 2006 10:15:41 +0200, Tristan Gingold wrote:
> [-- text/plain, encoding quoted-printable, charset: iso-8859-1, 34 lines --]
> Le Lundi 21 Août 2006 11:41, Keir Fraser a écrit :
>> On 21/8/06 10:20 am, "Tristan Gingold" <Tristan.Gingold@xxxxxxxx> wrote:
>> >> Fine in principle. Specific comments:
>> >>  * powerpc should be cleaned up at the same time to use the common
>> >> infrastructure. I don't want duplicated code hanging around in
>> >> arch/powerpc
>> >
>> > I have attached a blindly-made patch again powerpc files.
>> > If ppc people could check this, I'd be happy.
>> >
>> >>  * The code you add to common/ should obey the coding style of other
>> >> files in that directory
>> >>  * Arguably we should have an asm-generic for the xencomm guest-access
>> >> macros. That's a Linux-ism which I think fits well in this particular
>> >> case.
>> >
>> > Taken into account in this updated patch.
>> Looks better. I assume you'll resend with signed-off-by when you want these
>> applied.
> Hi,
> here are the signed-off-by patches for xen.
> I took the liberty to add Hollis Blanchard in signed-off-by of the first 
> patch 
> because he is the primary author of these files.

I suspect that CC is better than Signed-Off in this case.

  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

Xen-devel mailing list