This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] RFC: xencomm in common

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] RFC: xencomm in common
From: Tristan Gingold <Tristan.Gingold@xxxxxxxx>
Date: Wed, 23 Aug 2006 10:15:41 +0200
Cc: xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>, xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 23 Aug 2006 01:11:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C10F3E48.11EA%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C10F3E48.11EA%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.5
Le Lundi 21 Août 2006 11:41, Keir Fraser a écrit :
> On 21/8/06 10:20 am, "Tristan Gingold" <Tristan.Gingold@xxxxxxxx> wrote:
> >> Fine in principle. Specific comments:
> >>  * powerpc should be cleaned up at the same time to use the common
> >> infrastructure. I don't want duplicated code hanging around in
> >> arch/powerpc
> >
> > I have attached a blindly-made patch again powerpc files.
> > If ppc people could check this, I'd be happy.
> >
> >>  * The code you add to common/ should obey the coding style of other
> >> files in that directory
> >>  * Arguably we should have an asm-generic for the xencomm guest-access
> >> macros. That's a Linux-ism which I think fits well in this particular
> >> case.
> >
> > Taken into account in this updated patch.
> Looks better. I assume you'll resend with signed-off-by when you want these
> applied.

here are the signed-off-by patches for xen.
I took the liberty to add Hollis Blanchard in signed-off-by of the first patch 
because he is the primary author of these files.

I don't know wether or not these patches should be put off beacause of the 
freeze, but they are a no-op for x86.


Attachment: xen-xccom.diffs
Description: Text Data

Attachment: xen-xcppc.diffs
Description: Text Data

Xen-devel mailing list