This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] RFC: xencomm in common

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] RFC: xencomm in common
From: Tristan Gingold <Tristan.Gingold@xxxxxxxx>
Date: Mon, 21 Aug 2006 11:20:36 +0200
Cc: xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>, xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 21 Aug 2006 02:16:23 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C10F2944.11DA%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C10F2944.11DA%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.5
Le Lundi 21 Août 2006 10:11, Keir Fraser a écrit :
> On 21/8/06 9:03 am, "Tristan Gingold" <Tristan.Gingold@xxxxxxxx> wrote:
> > xencomm is the ppc infrastructure to do hypercalls with guest physical
> > addresses instead of virtual address.
> >
> > Because ia64 should also use physicall address, I think it's better to
> > re-use the ppc code and to put into common code.
> >
> > I'd propose to submit this patch is every part is OK (ie no NAK).
> >
> > This patch creates include/xen/xencomm_access.h which is to be included
> > by asm/guest_access.h.  It also creates common/xencomm.c which is
> > compiled only if HAS_XENCOMM is y in Rules.mk.
> Fine in principle. Specific comments:
>  * powerpc should be cleaned up at the same time to use the common
> infrastructure. I don't want duplicated code hanging around in arch/powerpc
I have attached a blindly-made patch again powerpc files.
If ppc people could check this, I'd be happy.

>  * The code you add to common/ should obey the coding style of other files
> in that directory
>  * Arguably we should have an asm-generic for the xencomm guest-access
> macros. That's a Linux-ism which I think fits well in this particular case.
Taken into account in this updated patch.


Attachment: 1xencommon.patch
Description: Text Data

Attachment: 3xenppc.patch
Description: Text Data

Xen-devel mailing list