This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] RFC: xencomm in common

To: Tristan Gingold <Tristan.Gingold@xxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] RFC: xencomm in common
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 21 Aug 2006 10:41:12 +0100
Cc: xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>, xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 21 Aug 2006 02:41:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200608211120.36685.Tristan.Gingold@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcbFBfAULqj1nzD5EduDqQAKle7CWA==
Thread-topic: [Xen-devel] RFC: xencomm in common
User-agent: Microsoft-Entourage/

On 21/8/06 10:20 am, "Tristan Gingold" <Tristan.Gingold@xxxxxxxx> wrote:

>> Fine in principle. Specific comments:
>>  * powerpc should be cleaned up at the same time to use the common
>> infrastructure. I don't want duplicated code hanging around in arch/powerpc
> I have attached a blindly-made patch again powerpc files.
> If ppc people could check this, I'd be happy.
>>  * The code you add to common/ should obey the coding style of other files
>> in that directory
>>  * Arguably we should have an asm-generic for the xencomm guest-access
>> macros. That's a Linux-ism which I think fits well in this particular case.
> Taken into account in this updated patch.

Looks better. I assume you'll resend with signed-off-by when you want these

 -- Keir

Xen-devel mailing list