[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2 09/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU suspending
- To: "Quan Xu" <quan.xu@xxxxxxxxx>
- From: "Jan Beulich" <JBeulich@xxxxxxxx>
- Date: Fri, 29 Apr 2016 01:13:30 -0600
- Cc: Kevin Tian <kevin.tian@xxxxxxxxx>, Feng Wu <feng.wu@xxxxxxxxx>, Liu Jinsong <jinsong.liu@xxxxxxxxxxxxxxx>, "dario.faggioli@xxxxxxxxxx" <dario.faggioli@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, StefanoStabellini <stefano.stabellini@xxxxxxxxxx>, Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>, AndrewCooper <andrew.cooper3@xxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>
- Delivery-date: Fri, 29 Apr 2016 07:13:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
>>> On 29.04.16 at 04:41, <quan.xu@xxxxxxxxx> wrote:
> Now I check the status in caller to make the print include caller which is
> failed, instead print in iommu_flush_all().
> i.e.,
> vtd_crash_shutdown()
> {
> ..
> if ( iommu_flush_all() )
> printk(XENLOG_WARNING VTDPREFIX
> " vtd_crash_shutdown: IOMMU flush all failed.\n");
> ..
> }
>
> I am afraid I still don't get the point. To be honest, in such a fix,
> The print is not so useful to me ( Correct me, I will continue to enhance
> it).
So do you think it would be more useful to leave the admin with no
clue why a system misbehaves, instead of providing clear indication?
IOW - what usefulness concerns do you have?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
