This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: RE: [Xen-devel] wget and Zope crashes on post-2.0.6 -testing

To: Kurt Garloff <garloff@xxxxxxx>
Subject: Re: RE: [Xen-devel] wget and Zope crashes on post-2.0.6 -testing
From: Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxx>
Date: Thu, 9 Jun 2005 10:18:39 +0200
Cc: Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Kip Macy <kip.macy@xxxxxxxxx>, Rich Persaud <rich@xxxxxxxxxxxxx>, Osma Suominen <osma.suominen@xxxxxxxxxxxx>, Gerd Knorr <kraxel@xxxxxxx>
Delivery-date: Thu, 09 Jun 2005 08:17:48 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20050608205900.GC12001@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <A95E2296287EAD4EB592B5DEEFCE0E9D28212C@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <20050608205900.GC12001@xxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Wed, Jun 08, 2005 at 10:59:00PM +0200, Kurt Garloff wrote:
> -
> +     
> +     fpu_begin();
>       /* Test for the divl bug.. */
>       __asm__("fninit\n\t"
>               "fldl %1\n\t"
>               "fdivl %2\n\t"
> @@ -108,8 +109,9 @@ static void __init check_fpu(void)
>               : "=m" (*&boot_cpu_data.fdiv_bug)
>               : "m" (*&x), "m" (*&y));
>       if (boot_cpu_data.fdiv_bug)
>               printk("Hmm, FPU with FDIV bug.\n");
> +     fpu_end();
>  }

This would works too, but I choose to just reenable the TS flags,
because at this boot point, we don't even care about what is already in
the fpu when entering the inline asm, we just want to take the next FPU fault.

kernel_fpu_begin/end() is more for saving FPU userspace context for doing
something that need FPU in kernelmode. That's probably why this test has
not been wrapped on vanilla kernel.

Vincent Hanquez

Xen-devel mailing list