[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 05/11] xen/device-tree: use p2m_gpa_bits in common code
- To: "Orzel, Michal" <michal.orzel@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Date: Thu, 14 May 2026 09:19:53 +0200
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:In-Reply-To:From:Content-Language:References:Cc:To:Subject:User-Agent:MIME-Version:Date:Message-ID"
- Cc: Romain Caritey <Romain.Caritey@xxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Luca Fancellu <luca.fancellu@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- Delivery-date: Thu, 14 May 2026 07:20:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 5/13/26 1:16 PM, Orzel, Michal wrote:
On 13-May-26 13:14, Orzel, Michal wrote:
On 07-May-26 10:58, Oleksii Kurochko wrote:
The IPA terminology is Arm-specific, so rename p2m_ipa_bits to
p2m_gpa_bits to use architecture-neutral naming in
xen/common/device-tree/ code.
No functional changes.
Reported-by: Jan Beulich <jbeulich@xxxxxxxx>
Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
---
Changes in v5:
- Rephraze commit subject.
- Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>.
---
Changes in v4:
- Nothing changed only rebase.
---
Changes in v3:
- Introduce #define p2m_gpa_bits p2m_ipa_bits for Arm instead of
renaming of p2m_ipa_bits to p2m_gpa_bits to keep Arm part of
changes clearer and keep using Arm-specific terminolgy inside
Arm code.
---
Changes in v2:
- New patch.
---
---
xen/arch/arm/include/asm/p2m.h | 2 ++
xen/common/device-tree/domain-build.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2m.h
index 010ce8c9ebbd..7957dbd96e57 100644
--- a/xen/arch/arm/include/asm/p2m.h
+++ b/xen/arch/arm/include/asm/p2m.h
@@ -14,6 +14,8 @@
/* Holds the bit size of IPAs in p2m tables. */
extern unsigned int p2m_ipa_bits;
+#define p2m_gpa_bits p2m_ipa_bits
This deserves the comment e.g.:
/* Common-code alias; ARM keeps the IPA spelling internally */
With that:
Acked-by: Michal Orzel <michal.orzel@xxxxxxx>
Thanks!
Forgot to mention that I'm ok to do this change on commit (patches 1-5 are ready
from this series).
I would be happy with that.
~ Oleksii
|
