[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/shadow: deviate guest_va_t wrt Misra C:2012 rule 5.6


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
  • Date: Thu, 14 May 2026 07:13:31 +0200
  • Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
  • Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1778735611; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=qMgjClQG4L0Cwyij0BS7SjO9YGLwjbCqLC4+pd/ehuY=; b=GCttkv0KgW4YdmwUkdmrlLifMbd8YYpGqHd27oKo+GVvu43M6huEpFy0dfkEwQVk3l0X C4Bq865lMTmPHUesbLaUo4c0xJ8xbUrAvCe2KtLdnXSLbf5q/X0zndBMzTQUm102yYjdQ S2ytP47WIrSNgIguRCAjufyMEqtdIQbfxrFKMcXk4ktOtN9aqUmKyBx45vm3zTRFbG6fx uBvoWDdERkFSa/0jAZrx2prgGGWEZFWOlZtjQ37wMU1NMHKRt4muzsSWEbyNTFStdiK5H iJyI3jWMNXr6nyquKdegO9si9nUq19lYwiCaanmgUndhb8ltRdsIdTu/5g5KpK/RT9aKr 3gvD3PnT81FfGrsir+TKuqVcUYv7RGL7CgcCNMCsDMBU6JQ6OkIP2JDJv5NVuHrPI8utH +WfUXw6rrDdrNqXwIvHNwQ6GchuIVyGrN/EsFfkc/3KjJLVj6GTy5sG9EhAomPLQ7/OcY q/SClOcmdw0Yi+cvhL4X7+9hHhqjql7/ZryoAK1CVJuhkA5B5hIaaZ8ZOmsLYEPf/anHp 6yg2WCMFJlB1h30RT38f4ca2ySKfeXbhq0MFFJZ07JhUTY57eXeGSDfe0MAfssQBkWqMq k456tILie2TqJcmMs4cuB19NZZrtchJMQFJiUInYLtNaCw0ccgbS/fEosYWH3Q8=
  • Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1778735611; b=o4LYxBwvn6sKBJvvv8iC0km2iJEX+krdKHCzU5aDaBBep9QsB8gISDaJCSMWQjI7esSg xJNPhCaTBNidtBCQWuA5ofkBANRoVQ8u3EMzCh4ylGM3t/WK+4uXNYQDE+l51aqqknJfF VnPbh93zI4IhwuBZH7fH/GrL5rmU5jOSdHbvU9fMEvkAX+TWcbKT9EZwbY4kh5Ob3Poid h10tMllmS85UezQeOS3r+CyrkhyTKffjs05qJD8B2derQA4fr+6yhvWSTtc1ncdwqka3C 575jVJK9wRoQUyWhrJ5QRjiByU4VHtaIP32dFXKjGHCCgS8HgpdJi4jqFKrCVI9Zr/KnK j6GQsiCwh2mHYAExyeyB33Ntn9lY16WnoNUabVP8teAbnIyWWvT6zBWtRjmOlGmj7DadW UGhZ8duKtGohheCCZYDOexgW4HNNpyRnzM7fOT0un4wJ2x+Wkk+KbIslCO+xZHHon0dGM BBKZ2jzlEJPiT12UOP5XaBW9bcRarXjrkUWXBKx4ajXLi8tjZQ7cm8fdeMMiD2owTySHd tBV5KkUgZNR8JXPrD9bh9AELykA2dob6uzqnx4iaMrC1Mqd/YW58PDC0TcVZI7nlVF6hH gC3B/UZJsXTE607y5AK/hYZq56hiMHB/bFsA7QbbZGXLjUkyT3l5ll6ORuejCjE=
  • Authentication-results: eu.smtp.expurgate.cloud; none
  • Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>
  • Delivery-date: Thu, 14 May 2026 05:13:39 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2026-05-13 13:48, Jan Beulich wrote:
... ("A `typedef' name shall be a unique identifier"). Much like already done for guest_intpte_t and guest_l[12]e_t, but limited to shadow/multi.c.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>


--- a/automation/eclair_analysis/ECLAIR/deviations.ecl
+++ b/automation/eclair_analysis/ECLAIR/deviations.ecl
@@ -143,6 +143,11 @@ number of guest paging levels."
-config=MC3A2.R5.6,reports+={deliberate,"any_area(any_loc(file(^xen/arch/x86/include/asm/guest_pt\\.h$)))&&any_area(any_loc(text(^.*(guest_intpte_t|guest_l[12]e_t).*$)))"}
 -doc_end

+-doc_begin="In x86 shadow code, the type \"guest_va_t\" is deliberately defined
+multiple times, depending on the number of guest paging levels."
+-config=MC3A2.R5.6,reports+={deliberate,"any_area(any_loc(file(^xen/arch/x86/mm/shadow/multi\\.c$)))&&any_area(any_loc(text(^.*guest_va_t.*$)))"}
+-doc_end
+
-doc_begin="The following files are imported from the gnu-efi package."
 -file_tag+={adopted_r5_6,"^xen/include/efi/.*$"}
 -file_tag+={adopted_r5_6,"^xen/arch/.*/include/asm/.*/efibind\\.h$"}

--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.