[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 05/11] xen/device-tree: use p2m_gpa_bits in common code
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Wed, 13 May 2026 13:16:09 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z6ctmR95F2abZpp2TiEnYeOb23ZkcIQWevkFBVpF5FA=; b=AlOMN+GiiAMTTP61vQ9SLfzUtE4YmtC1h9eDRoWGtUD57eg/9vyYU5UEweqFufCrOOkoDJwaD2zM+zhqX9s77ZrudIJ5Wva8EGH+++5LhE0CQtqTND+qhGMW25gFZqHPgDQPf9ACeZokmiELB6E9PbPMFjSL+ZbBloDT3MULhebeUKQVxgzyOsF1BlhgRcaSL1wjxtoET7fpFdw/kw30UONxlnnkLQZltoJNlYD4zXjRiIKKUMkJnemAR3UeD93zpI3wDxKJf+dhIfy54mZ/Thw3uVKvRjmcQWasgiQFZphTWi451jOpFH39sNWpZWb9aLy0fHLA6YRjlWeiFrt9PQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GpMT63Tqzvb7hYg5Ke6V7IJ534Jhtedn9qysaA198c8nAYc+SoidacOfPwTGckPz1gBwV+dVMenhonbREF1mU+dy2yXeyZvtdkFy7V3Xp2c//mvgkDx9hVcAe9POqFTR1U3NcVE1gbr+iY3dyqeknpGCIcEURDsdWiVBpLZb6/+G7BIQWXpVdmoETzDXtHNzhxKwzmG8KRGO9QPcuGnMcAFHvEfyYwzIS8Pv7wdQ/TYnv5nDKA8ROa9KbBTPELX24jWxeYFYHhQqQTg3U5RnnzZe0eEhxtNFk31M+ryo1NtoFgg+qVFMAqaL3FWTNtuS10IYp7uPVxYHR3W+Lyum0A==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Romain Caritey <Romain.Caritey@xxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Luca Fancellu <luca.fancellu@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- Delivery-date: Wed, 13 May 2026 11:16:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13-May-26 13:14, Orzel, Michal wrote:
>
>
> On 07-May-26 10:58, Oleksii Kurochko wrote:
>> The IPA terminology is Arm-specific, so rename p2m_ipa_bits to
>> p2m_gpa_bits to use architecture-neutral naming in
>> xen/common/device-tree/ code.
>>
>> No functional changes.
>>
>> Reported-by: Jan Beulich <jbeulich@xxxxxxxx>
>> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
>> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>> ---
>> Changes in v5:
>> - Rephraze commit subject.
>> - Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>.
>> ---
>> Changes in v4:
>> - Nothing changed only rebase.
>> ---
>> Changes in v3:
>> - Introduce #define p2m_gpa_bits p2m_ipa_bits for Arm instead of
>> renaming of p2m_ipa_bits to p2m_gpa_bits to keep Arm part of
>> changes clearer and keep using Arm-specific terminolgy inside
>> Arm code.
>> ---
>> Changes in v2:
>> - New patch.
>> ---
>> ---
>> xen/arch/arm/include/asm/p2m.h | 2 ++
>> xen/common/device-tree/domain-build.c | 2 +-
>> 2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2m.h
>> index 010ce8c9ebbd..7957dbd96e57 100644
>> --- a/xen/arch/arm/include/asm/p2m.h
>> +++ b/xen/arch/arm/include/asm/p2m.h
>> @@ -14,6 +14,8 @@
>> /* Holds the bit size of IPAs in p2m tables. */
>> extern unsigned int p2m_ipa_bits;
>>
>> +#define p2m_gpa_bits p2m_ipa_bits
> This deserves the comment e.g.:
> /* Common-code alias; ARM keeps the IPA spelling internally */
>
> With that:
> Acked-by: Michal Orzel <michal.orzel@xxxxxxx>
Forgot to mention that I'm ok to do this change on commit (patches 1-5 are ready
from this series).
~Michal
|
