[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 05/11] xen/device-tree: use p2m_gpa_bits in common code


  • To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: "Orzel, Michal" <michal.orzel@xxxxxxx>
  • Date: Wed, 13 May 2026 13:14:47 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r/OLRIHqLJektnMGyGVA0cjMD0CGXKpbqesJdkd3mcg=; b=OQItAywQfF0YvThZ3b9UcUPTQ6gKF3IjDsM/vZiDSAqoeAB8Y1+uygZPdhmhiLzxCrVPRVHigao4qZY2vf1+LlDC4hMWUo5qxZdt8GTnPP+JVkBTucRk1eq4XamAyUNWDmlrJRpSiizx2eMBO77lb6vQJbi8aHwsXEcR+TAdSS0rCd6pK2pw5QCroUuakOMw/8LhJZut8MpX0IsrlXUgFQ6x96MQ38bx455R29cGcvBNSjV7+Pmh2X9oESbZvziiWPdda4MvbANXqTUKZHwHOBcHDP7UcKu/M6sodl5lZuwuztkB40k8e1tvZt8sX7XqK29D81hIiC5x1lLqhPd+/g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QO4gTSTjCUIQU6BrRFsak6fSQeCq79A3W2uomMWCgi+UB5A/Ja2K33Zx/2hZVkywPxEFpqHO5/YxNln6KowD8HNKKVZ2J8tc3XLWLQIn5gKelwR4X1Q5RhEYQiW1aLYYScJB2920JyiWqyqvcOHqmwFTidwO9GXYCMFI661eaZPgPlN7vG3acjrqb7sjwsI8ffF8U4suvKnN319j6ZsU20qXNQCwzUpK8zniUm1RoEvCmwOExTN7iLotGkBe/a8JoyCPDE3Qv0GUTAKzDEl3asMaQQaOJDYeuNJw/Hl0nC0iIG+CXb9q7Dl1oVUXQCrhjnQ5FkryLZFYQtrqbVdD9g==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Cc: Romain Caritey <Romain.Caritey@xxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Luca Fancellu <luca.fancellu@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
  • Delivery-date: Wed, 13 May 2026 11:15:04 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 07-May-26 10:58, Oleksii Kurochko wrote:
> The IPA terminology is Arm-specific, so rename p2m_ipa_bits to
> p2m_gpa_bits to use architecture-neutral naming in
> xen/common/device-tree/ code.
> 
> No functional changes.
> 
> Reported-by: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> ---
> Changes in v5:
>  - Rephraze commit subject.
>  - Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>.
> ---
> Changes in v4:
>  - Nothing changed only rebase.
> ---
> Changes in v3:
>  - Introduce #define p2m_gpa_bits p2m_ipa_bits for Arm instead of
>    renaming of p2m_ipa_bits to p2m_gpa_bits to keep Arm part of
>    changes clearer and keep using Arm-specific terminolgy inside
>    Arm code.
> ---
> Changes in v2:
>  - New patch.
> ---
> ---
>  xen/arch/arm/include/asm/p2m.h        | 2 ++
>  xen/common/device-tree/domain-build.c | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/include/asm/p2m.h b/xen/arch/arm/include/asm/p2m.h
> index 010ce8c9ebbd..7957dbd96e57 100644
> --- a/xen/arch/arm/include/asm/p2m.h
> +++ b/xen/arch/arm/include/asm/p2m.h
> @@ -14,6 +14,8 @@
>  /* Holds the bit size of IPAs in p2m tables.  */
>  extern unsigned int p2m_ipa_bits;
>  
> +#define p2m_gpa_bits p2m_ipa_bits
This deserves the comment e.g.:
/* Common-code alias; ARM keeps the IPA spelling internally */

With that:
Acked-by: Michal Orzel <michal.orzel@xxxxxxx>

~Michal




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.