Re: [PATCH] fully replace mfn_to_gmfn()

[Julien Grall <julien@xxxxxxx>]

Hi Jan,

On 28/06/2021 17:15, Jan Beulich wrote:
> On 28.06.2021 17:42, Andrew Cooper wrote:
> > On 28/06/2021 12:52, Jan Beulich wrote:
> > > Convert the two remaining uses as well as Arm's stub to the properly
> > > named and type-safe mfn_to_gfn(), dropping x86's definition (where we
> > > already have mfn_to_gfn()).
> > >
> > > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> > Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, but ...
> Thanks.
>
> > > --- a/xen/include/asm-arm/mm.h
> > > +++ b/xen/include/asm-arm/mm.h
> > > @@ -328,8 +328,7 @@ struct page_info *get_page_from_gva(stru
> > >   
> > >   /* Xen always owns P2M on ARM */
> > >   #define set_gpfn_from_mfn(mfn, pfn) do { (void) (mfn), (void)(pfn); } while 
> > > (0)
> > > -#define mfn_to_gmfn(_d, mfn)  (mfn)
> > > -
> > > +#define mfn_to_gfn(d, mfn) _gfn(mfn_x(mfn))
> > ... surely this wants to be ((void)(d), _gfn(mfn_x(mfn))), even if it's
> > just a latent bug right now?
> Well, Julien said he plans to get rid of this anyway. I'll do here
> whatever the Arm maintainers say is wanted. Julien, Stefano?
I am fine with the change suggested by Andrew.

Cheers,

--
Julien Grall