[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fully replace mfn_to_gmfn()
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 28 Jun 2021 16:42:46 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fzsyPWRkH/AuOxaHf9zOdo6QAdP0gtCntHQtxnq4QMw=; b=J7odn7z900X6rLU7bDcwu8x5hknlxGUwZfq2ObQC8qEevC20qRlUC653AXOzMUvlL1S6M109Zgobe/LuZUWwPu9ZXaqfFlnVd+VYRkDZVm3ZxdXSOMHX4iZvEP1X/FZkQ/PFz/qdmidQGRB1WXXOzHFg2prTd4YgSO4jeDf1dzu4wbt2q4Jmb3BBHy6XgIuKmwNISTMpQGqJSOzezshd/2KTWbFV77Cf/BFUVI3HFevC2Di8Ag9gn+EsCmMSrETC1irZ83IhfAp6PqIO1YuSgtWeUVo7oIwVl/ADIYBflwITMl3QknpOD1M9zZFbawk7OT6fR9KPVIOO8O3QP1YmrA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bH1lvMs4iG34ajPmrEzjISFlVaW8jOlueTyu/B4V2ZTWHkIQsLNXdDWGnC7uSftL/GO7mkt4GQ4CSBNKGt5g1mO4IlS0UxHMTeTgerKto+Qj4FtwhvbrRqzqsvs1GwpCDUUS1y5r3qR4v47XeMFlyNje9sS4Z7DUQtiq9n7EaF7idZfh8X3q+FOzuMFDvbfXhTwQtfJkdnnDeUm6RrVmw6CAgtelreIAqy/vnispUogBRUG/1zs4NxLCTGaPy5FEWAWVMTuEpBOJgXBiIVp8faHFGT33COeExDACIx5iaGvueyJMrBDgPCW9zN1ybUd9H5Rb390YIXv1E/Sdc0dBhg==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 28 Jun 2021 15:43:12 +0000
- Ironport-hdrordr: A9a23:rhL2qaNtdSFZDcBcTyX155DYdb4zR+YMi2TDiHoedfUFSKOlfp 6V8MjztSWVtN4QMEtQ/uxoS5PwP080kqQFnrX5XI3SIDUO3VHIEGgM1/qY/9SNIVyGygcZ79 YcT0EcMqyDMbEZt7eD3ODQKb9Jq7PrgcPY55ar854ud3ANV0gJ1XYLNu/xKDwSeOApP+tcKH PR3Ls8m9L2Ek5nHvhTS0N1EdTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S yd+jaJppmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e O84isIDoBW0Tf8b2u1qRzi103LyzA18ULvzleenD/KvdH5bChSMbsFuatpNj/ir2YwttB116 xGm0iDsYBMMB/GlCPho/DVShBRkFauq3ZKq59Qs5Vma/pYVFZtl/1YwKsMe61wRR4SqbpXU9 WGNfusoMq/KjihHijkVgAF+q3YYpwxdi32D3Tq9PbliAS/MRhCvgMlLfck7wE9HaQGOtN5Dt T/Q9NVfY51P4YrhIJGdas8qJiMeyPwqSylChPYHb2xLtB3B5uKke+s3IkI
- Ironport-sdr: xTP84Sw6YhutYAXXiwS7ZY3bTOGJhQxUxUvKR6z2xR9i6wGeyIFFpQso/dZDi7a8WzeyK74QUD qTKSkzwEEr9EigNOiiXFQrrhCfYBvaxviey3nSWMN+Mnpf0ZQRQiv9M78XS1xCTdWoYmKxMJe1 aHLTWMOWwyO8I0VzN6+CQ201Q6lyVCVlx1dFUpp74EoCrS1mGuHrxc8oT2M4xvdQCVS5O6Um4b GO5voTfXzN+32iKnDUrU3p6kkkGXYxGlQQE9TZ8ZsW5sPEhSbvPj/Z2GS9gXoEh1XwAFiIuj+x +LA=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28/06/2021 12:52, Jan Beulich wrote:
> Convert the two remaining uses as well as Arm's stub to the properly
> named and type-safe mfn_to_gfn(), dropping x86's definition (where we
> already have mfn_to_gfn()).
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, but ...
> --- a/xen/include/asm-arm/mm.h
> +++ b/xen/include/asm-arm/mm.h
> @@ -328,8 +328,7 @@ struct page_info *get_page_from_gva(stru
>
> /* Xen always owns P2M on ARM */
> #define set_gpfn_from_mfn(mfn, pfn) do { (void) (mfn), (void)(pfn); } while
> (0)
> -#define mfn_to_gmfn(_d, mfn) (mfn)
> -
> +#define mfn_to_gfn(d, mfn) _gfn(mfn_x(mfn))
... surely this wants to be ((void)(d), _gfn(mfn_x(mfn))), even if it's
just a latent bug right now?
~Andrew
|
