[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] x86: drop a bogus SHARED_M2P() check from Dom0 building code


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 28 Jun 2021 13:52:52 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9ZczkSMCRVUGG35vGro3rUeJaFaSvSdJdIGBjDs1ovM=; b=nTq0S6jTU2PYi4m3uLor3sija4Ge32i3/p1Dtc8LEphZNjkMt8reuoX/JmSGIgJurNYZlcDKXEKic7uzRMvVMWOfBMdZzdzmoiqzc/lplLppv9H7HMB/Bf2ggF4VRLZ8TCpK/i1I3BmZfYPqSptFrbcpeCRYOQEhCzUb1QGXYf1dixhZOpCTvmGf5OGr21scfUMNtQaeECIoDT6cmhkO/gEoize9weoNokAMFEpmvxSg8Sm8Yv+Tz7miOiYYmlaja2lT8K0lAqXKc8klhfFwfzaxU19GeHLsvhXEgqp5OoG3Tn1A7m2Ff8q4hfPVjclHnAtF1JjCQEf1RGi4rqPS2A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hY1Y04TdxN/UBNm+8TNrafGM9yyJLGr/TYIjVTGgjYStlwGIjErvXalfXz2jatYdNBGLIia95hwhC+4L6BhAfr1QInHqveDUyy7bkBt65RfFZNILqAI2+fHrLQxQt+LDWwvVrIb0vEq3xTmtUMXpzrgbm5s+GfXbszYpdAqnrNuljy8bL7vtqgFP3CaMY8mRXF6EBRGbyeBWWeEa8hsLlkB+MtW3+HI19lkd87BAiZ+sKu0qkZ4FSkB80Lz6jDeJyrgqTja+EvsybK2kmINoxYGvQMuKTIQP/GZM3dZygNE5zitUfZAZGPdoXm1j0VSDnXBrMbxCFcAdaUTCLfgZ2w==
  • Authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Mon, 28 Jun 2021 11:52:59 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

If anything, a check covering a wider range of invalid M2P entries ought
to be used (e.g. VALID_M2P()). But since everything is fully under Xen's
control at this stage, simply remove the BUG_ON().

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- a/xen/arch/x86/pv/dom0_build.c
+++ b/xen/arch/x86/pv/dom0_build.c
@@ -815,7 +815,6 @@ int __init dom0_construct_pv(struct doma
     page_list_for_each ( page, &d->page_list )
     {
         mfn = mfn_x(page_to_mfn(page));
-        BUG_ON(SHARED_M2P(get_gpfn_from_mfn(mfn)));
         if ( get_gpfn_from_mfn(mfn) >= count )
         {
             BUG_ON(compat);




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.