[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fully replace mfn_to_gmfn()


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 28 Jun 2021 18:15:18 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pbJpNJLR8C8ufDmrtZTnOf4qQUfD4rly0HHSesBAlWo=; b=mj2CmqCW/ynahqJSPGb2tcfT9wMJx21j/laxVOTxHnjnMH3vc5QeN3hKBGwzfytF6aLKGfCBaanrfF9eDOCt1lrtkBgjBC7x61Rg9UD3Gr/dbL6EOzNSdbt7OC4OAx2eg1bCqNkSpaeCXmSXtRVR57MtTbqX6dWe+D4ld+9hzrMv6CC1NHxb4esl/hoNFur9a5qTNaAosF7XVdvwEV+0yWESjlI/X9dJQ/4wPPPcRWNSQOYB/R2dzg4r10Fb+y9Vw/DI4+uQBSiE6WZD9dn/lbIovxH24LnKfyGRC2UJPutWrmZSXvHAFM7EzNAteG00TM9EDLbRTQHFGVYbcs89Mg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BW3XZrb7GAcvRacdvJYmJAfkYOD4OVIgHzsE7QaQCIT3tU8F5z+8ocZibU2SNS9/xKs/qlCs22qUBG6gVb1pJXfQa0Pti7/zpG70o7nAWJoV3y8JC4q8vS7MMMj6VXWIRI57x+pAfO7cqCB8ABdgeee0cCYVsf7pjAnJnaomoMuw3/Cjdy+nw/ZRRa29ZM0r/akuWXQmj4s5otXZIOc7+ryctsvbdbciIyg8fU6Ov+zklkKwSuaVAIu58JSGIjEcmWwZyQ9LEYiWhCTY3BvzUrfNRPvT7SIZn840GS6PQgRQHS4uBAxeIRixnwiiICwNMVmjdX+EuxlDlWvWRSzdIg==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 28 Jun 2021 16:15:29 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 28.06.2021 17:42, Andrew Cooper wrote:
> On 28/06/2021 12:52, Jan Beulich wrote:
>> Convert the two remaining uses as well as Arm's stub to the properly
>> named and type-safe mfn_to_gfn(), dropping x86's definition (where we
>> already have mfn_to_gfn()).
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, but ...

Thanks.

>> --- a/xen/include/asm-arm/mm.h
>> +++ b/xen/include/asm-arm/mm.h
>> @@ -328,8 +328,7 @@ struct page_info *get_page_from_gva(stru
>>  
>>  /* Xen always owns P2M on ARM */
>>  #define set_gpfn_from_mfn(mfn, pfn) do { (void) (mfn), (void)(pfn); } while 
>> (0)
>> -#define mfn_to_gmfn(_d, mfn)  (mfn)
>> -
>> +#define mfn_to_gfn(d, mfn) _gfn(mfn_x(mfn))
> 
> ... surely this wants to be ((void)(d), _gfn(mfn_x(mfn))), even if it's
> just a latent bug right now?

Well, Julien said he plans to get rid of this anyway. I'll do here
whatever the Arm maintainers say is wanted. Julien, Stefano?

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.