[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-next 5/6] xen: Add files needed for minimal riscv build

  • To: Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 26 Feb 2021 16:56:32 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9hoPS/paFSn1bbFxqzXZ9/mrVuQvZQ+8Ti19QRzKOPg=; b=MW3HwasM8UlL9MBIUJ2TN1279A++OkIgSxngRFNeLZbe3Qty/1asv2radZgHTkcKnvymGTifLMYxpuTidqTaYtJN5+iHF2RWAiBkUc8eCkHueQqpxH0YgdNw+xZ9a8aemBbZeTDYXmzwYqfydSayzwY5ggWLLFm+tH2R30pKwpmzn3DXmZSd5cqzk3qXcxQKJbtdwZanjgWdR7NyozHFNAe/N9+36cOkTcNRfPdLhziNjb6ukvRgD6lLLmx+9NsoQhHJxpGUKpNuc9zjTfTMS81aGz3hJ99X0I6Rvekr56zdL/2LR4jT7HI5EnCOA4slGXMVHjz0PXFU1QwvMgcEjA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XXIZfLHZJOL3Vt43JqA67bidLDugjzm01WA74kYsh4hKPvtLRrJzWnPLkGrcmaWZDTWqs7touCtW/gpkdimHSacdcuNXFQzZ24gYjHCPXrzqtYhIF2syMxXXkLIEsCZvydEcCCv0dz85/u9VouTxz1fbpR4qdnsq8FXD/pa2eKZyL9y0iafV2jX5R/GS98PA/LUy+2bBRUrBSbpUPozQgZv997P30OnRThVDY13jhRjhwtviPPicVn6YXDccMyGxLgIvOfpzTfju4qRxjjFNms6DbdNZwEIqnftWeHmZC1fxDJpy1XRmFiA8SIowLAyY6ysh9eynZ4PfrqPYcR93Hw==
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 26 Feb 2021 16:57:04 +0000
  • Ironport-sdr: FWMcR9mtOiyoi2rPVN6rkM/o8QDUh6FJXGbkHTy4n1rOA7ULk3UAswna5Du4Em7hdwksVej4ep ABVytrtdlkvxbxO7H5yPXuMQy3lneEUQZXhf3kpYd353DeT18yENZiK8BckkkmD4eIOA+I8ruz /9Lu1E5ckj1o44/6LwlYu9aaCMqv7STQwba+sHRiUus+Au602bupr3Qar2UiFmbqqM8VPfttal nzG2IyZJmMxivGMVgvx/Rc2F6P6OmqEkTkXAKkns5g3LcRTGPjlKAW8StL6blyaQcZvJuXPhbV kR4=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 26/02/2021 16:21, Bob Eshleman wrote:
>>> On 2/25/21 3:14 PM, Andrew Cooper wrote:
>>> It sounds like you'd prefer no common to start and none of the
>>> arch_* calls it relies on?
>> We definitely want "stuff compiled under RISC-V" to be caught in CI, but
>> that doesn't mean "wedge all of common in with stubs to begin with".
>> Honestly - I want to see the build issues/failures in common, to help us
>> fix the rough corners on Kconfig system and include hierarchy.
>> In light of this patch, there are definitely some things which should be
>> fixed as prerequisites, rather than forcing yet-more x86-isms into every
>> new arch.
>> ~Andrew
> Ah I see.  There's more that could be Kconfig'd away and if they can't be
> Kconfig'd away, their should be some commits to make it so they can be.
> But things like, for example, `arch_domain_create()` would still
> be stubbed, because this is and always will be required.

Some bits are very mandatory (at the point you start compiling
domain.c), but it absolutely shouldn't be necessary to implement that
much in the way of stubs to bootstrap an architecture.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.