[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-next 5/6] xen: Add files needed for minimal riscv build

  • To: Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 26 Feb 2021 15:55:37 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d97pyAgV5MagtV0sq9xH5n9k/J5bO4lCyXUNK6r1bRI=; b=ncevfVhZUde8aIPtCK9bS/l/1t4+ZjeIdQ3sHcen0R8NxnCZXBhQoBXhZGD/vkLDhiRyu/FyTOcPNlx6gLjexO8fXoTvfMJDPscKesDFxAucAP0RKwwTMteJx7VSbagVL5IlWTbjyI7ESVxRy0eHbQFcW+HZTFs3dOPtBu3iX95hdM6hI3THouCiMwNsv6yUdd2EUprSJBrWrfNDiScGu8PPJwnuEGisgrE02sNRtf+OECtEMN755S9557R9tO8aX2bsYnVEVbEzVJehC3RFwoE0nj+me7jMVQkVoUKem9VurG1k5MZAcSFRcmccRDgVDeEzKZngddGirudVWLm1Mg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=htX/Opr//tpXCD4rQJFBsyDqsIjODgPoW9hA6SE6xp7IcVhFW+eMymoBk0RkJWc7uKvfejLHz+D4dL9Foy0/O3JXiBwG1NdM2k5H6KTsjpxflzd5jrDwpMzBXgZZl7sQzgCKA8wFVyKh/APBv/mXtw/3S5SW6EBladzBAj7sovvXS4qn93v/EbDlefZJD+l8qDx6b7epub70vrstTgRsmp+id5ZXqhuWthj1jwbZ6Mlf7WYIsEJo9jTfqPDtrFS5IJzUCn9p6uWfw2GPzXCyj+Jc+Y1bR5+OCDs5cFt56iWnRdm9XIZyEPzNudjeQRAAmwtLLq6jBdkXi358A090KQ==
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 26 Feb 2021 15:56:08 +0000
  • Ironport-sdr: 8wHP6e79kLa1tVYcmZrRqRVs/kDHvXEj8gM3B2aHXzMcwlENrIzUxkzPk1+Zu15M13jb9avYn5 SdlMcMenshGkzhhGZI2GZgj9bDiBq3w7Memqlmq819IV1AVzmH9BZjYIjjaWFW3s9U2wlcE2nY JHpmi56iX53UZzdE1gUAf4ITTRnxYmxwE/lfwO1IJ557W3ICIQ0PWQsrnYUaUBN3tZwYevBCe9 mesQIIMl8Zah4UykE1QstIcL3HuJGWe6vTw4r+cdlQjm3GnQUWnyiWjF79iymARG3/iZS1g/1B 0gA=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 26/02/2021 15:30, Bob Eshleman wrote:
> On 2/25/21 3:14 PM, Andrew Cooper wrote:
>> Well - this is orders of magnitude more complicated than it ought to
>> be.  An empty head.S doesn't (well - shouldn't) need the overwhelming
>> majority of this.
>> Do you know how all of this is being pulled in?  Is it from attempting
>> to compile common/ by any chance?
>> Now is also an excellent opportunity to nuke the x86isms which have
>> escaped into common code (debugger and xenoprof in particular), and
>> rethink some of our common/arch split.
>> When it comes to header files specifically, I want to start using
>> xen/arch/$ARCH/include/asm/ and retrofit this to x86 and ARM.  It has
>> two important properties - first, that you don't need to symlink the
>> tree to make compilation work, and second that patches touching multiple
>> architectures have hunks ordered in a more logical way.
>> ~Andrew
> I think we may have envisioned different things here....  I was under
> the impression that we wanted to implicate common, so that changes
> there that broke the RISC-V build would present themselves on CI...
> and to demonstrate which "arch_*" calls common expects to exist.
> It sounds like you'd prefer no common to start and none of the
> arch_* calls it relies on?

We definitely want "stuff compiled under RISC-V" to be caught in CI, but
that doesn't mean "wedge all of common in with stubs to begin with".

Honestly - I want to see the build issues/failures in common, to help us
fix the rough corners on Kconfig system and include hierarchy.

In light of this patch, there are definitely some things which should be
fixed as prerequisites, rather than forcing yet-more x86-isms into every
new arch.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.