Re: [Xen-devel] [PATCH v2 1/4] xen: sched: refector code around vcpu_deassign() in null scheduler

[George Dunlap <George.Dunlap@xxxxxxxxxx>]

> On Aug 5, 2019, at 6:30 PM, Dario Faggioli <dfaggioli@xxxxxxxx> wrote:
> 
> On Mon, 2019-08-05 at 17:04 +0100, George Dunlap wrote:
>> On 8/5/19 4:58 PM, Jan Beulich wrote:
>>> On 26.07.2019 08:25, Dario Faggioli wrote:
>>>> 
>>> 1) The commit is empty, presumably because I did apply the patch a
>>> few
>>> days ago already.
>>> 
>>> 2) The committer is recorded as "Patchew Importer <
>>> importer@xxxxxxxxxxx>".
>>> Do we really want to hide the fact who has been committing a patch?
>>> While it's mostly mechanical, there's still the human decision of
>>> "this
>>> is ready to go in" involved, which I don't think a bot can reliably
>>> take
>>> in all cases.
>> 
>> Both of these are mistakes, and due to the fact that I `git fetch`ed
>> patchew's commit rather than doing `git am` of the mbox provided by
>> patchew.  (And I used patchew's commit because somehow 4/4 didn't
>> reach
>> my inbox.)
>> 
> And this last part is apparently my fault, as your email address is
> actually wrong, in the Cc line of that patch.

That would explain it. :-)  But that’s by no means your “fault”: It’s very 
common for me to only be CC’d on a subset of patches in a series (e.g., because 
I’m the maintainer for some patches but not others), so “receiving a only a 
subset of patches” is something my workflow should handle effectively but 
didn’t.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel