[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 1/4] xen: sched: refector code around vcpu_deassign() in null scheduler


  • To: George Dunlap <george.dunlap@xxxxxxxxxx>
  • From: Jan Beulich <JBeulich@xxxxxxxx>
  • Date: Mon, 5 Aug 2019 15:58:22 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SzPGFZlRqq8P7L8kqJss0iNuUIL2Fvn7lKXk3Ni2I3A=; b=P6zjjwSjv0KFsdwlvqeRVfS/ieomP1WMJ11FmPS5UZa/VgLgM1iJByeKsWl21oF9RTjldu5bCqT7RNs5SgaEB++q9SkwNgbEaLhpWN4RiH+7UOPy71frEUUBAAWqOPt3SsZU3uj239Kxs/Z2wN52O1529OW9OEbGNZvslKp2AOe3XYkr0da5cyZ+FEcjvjAiI2rWPbAFAI2ZtDlldgDMRK2MmWTt7iv3/I2ftqCSTYUgE7o/JZfSo0cevDeIUoKlvabtbvciMB7wGnBZvkOJb0KbbQjLia3HYroLQ0N592hu/MvoR2yAxM4obkPkSvYB7hk3myEYeRllRfR7p5G2BQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D71Mh8xKGQ1+WOc7pVuFYKdMxTDAg0Ev+STCXSdsLQHunDrnZpeNHw9sg0rw9aySh6I/eOojAyiTpAC9WYpbsfrZLEyWGYjpD8BxUmaXHy1X9xqwHzT2n8V9diZCBln709mkkvPkNYK38Ot/sB4oBE4l+gSHAcbn6yQKBxks27vDO8fv+DFWueD+IA/OQwlgk2FroBwr7nZxutzG5fG6xfea9OsRXUKTHWXhWjryM7aqwGl5XV43jJhQJxNjV2+LhtSxSw6M5OZpw4KbSzfQFLOK5i1svo9EPC99zHlJRmFF6iZMzxjZcEWnTrkkiJMzGYJHvsloSztM1ldmXO+GRQ==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>
  • Delivery-date: Mon, 05 Aug 2019 16:00:47 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVQ3sg+fAdHgvAC0WLlVMWlooihqbsxjkA
  • Thread-topic: [Xen-devel] [PATCH v2 1/4] xen: sched: refector code around vcpu_deassign() in null scheduler

On 26.07.2019 08:25, Dario Faggioli wrote:
> vcpu_deassign() is called only once (in _vcpu_remove()).
> 
> Let's consolidate the two functions into one.
> 
> No functional change intended.
> 
> Signed-off-by: Dario Faggioli <dfaggioli@xxxxxxxx>
> Acked-by: George Dunlap <george.dunlap@xxxxxxxxxx>

I'm puzzled by commit a397471278, in two ways:

1) The commit is empty, presumably because I did apply the patch a few
days ago already.

2) The committer is recorded as "Patchew Importer <importer@xxxxxxxxxxx>".
Do we really want to hide the fact who has been committing a patch?
While it's mostly mechanical, there's still the human decision of "this
is ready to go in" involved, which I don't think a bot can reliably take
in all cases.

Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.