This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [patch] Xen build - Debian vs Redhat layout patch option

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [patch] Xen build - Debian vs Redhat layout patch options
From: Bruce Edge <bruce.edge@xxxxxxxxx>
Date: Fri, 17 Sep 2010 10:05:58 -0700
Cc: Olaf Hering <olaf@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 17 Sep 2010 10:06:52 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=o3LcR9KpU5LzF/L+QXmR2dAVKkaaCS+wq/7RmGalzxM=; b=Pg4bsK+j3uHi6GIBdYqB21L0hS/WrKgSTXuHzO9Fg+18m0aLltBmK/UWyInBRfhHZy o76bI+4p+qj5yU1qkbQ9YLqpAhvT+WpDRjF/RscrEOvRAYT2t8imlstG7oyH3eWrWKSb 7We1Xtxbmf0KLNa+pXWM/qDuHTQUcIiqN1JkU=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=hwAaORQBcyCS3sBOheFLuMaVo1XN829yHJGufcVAJW0+tYplHfXsINtVZ7UEj9cp9V FFZ5EKZ2S2rUa4JEotr6a1cudbVpPqm5c/VYu+yMO7gZXtJmyv9gTRU+IYcBMq23E4dJ bwdFSmdOCamk+njYvlmr4TZN2bn/aXVBBYnxU=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19603.37678.909565.298397@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.DEB.2.00.1007071207480.17029@kaball-desktop> <AANLkTi=2TveuUANkar9d89k_Ck22RWFDEB-bKnCanOuz@xxxxxxxxxxxxxx> <19599.43888.826450.690087@xxxxxxxxxxxxxxxxxxxxxxxx> <AANLkTik8b2evzTg8biVPVySvJTzVYmTSmSSt-WhbYrnD@xxxxxxxxxxxxxx> <19600.39408.486631.15438@xxxxxxxxxxxxxxxxxxxxxxxx> <AANLkTim8TGttxjWiVCnXrh9wyzpfaC6sd=MirvYUw__y@xxxxxxxxxxxxxx> <19602.17927.197275.274485@xxxxxxxxxxxxxxxxxxxxxxxx> <AANLkTi=vgZJZz+xbfgXNok6yvqTPh5xTDGS-OQ7VKW36@xxxxxxxxxxxxxx> <20100916204517.GA9380@xxxxxxxxx> <AANLkTi=S6ZL=1L9iX7W7JyRVMTWOS-GCO=wLoVr4CpC0@xxxxxxxxxxxxxx> <20100916205913.GA11392@xxxxxxxxx> <AANLkTimJCnnZDTY5tRep1ERj50rphWBXF+iT3bDR6eVQ@xxxxxxxxxxxxxx> <19603.37678.909565.298397@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, Sep 17, 2010 at 9:11 AM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> Bruce Edge writes ("Re: [Xen-devel] [patch] Xen build - Debian vs Redhat 
> layout patch options"):
>> OK, resubmit #3 with Olaf's suggestion.
>> No other changes.
> Thanks.  Nearly there I think...
> There are still a couple of occurrences of this:
>> +# See DISTRO_TYPE in the docs

OK, will fix. It changed so many times I forgot about them...

> which should presumably refer to docs/misc/distro_mapping.txt.
>> +CONFIG_LEAF_DIR  | /sysconfig       | /default      | /sysconfig     |
>                      ^                  ^               ^
> Not hugely important, but these slashes should be omitted I think ?

Yes, they can and will in the next round.

> Since CONFIG_LEAF_DIR is used and defined like this:
> ...
>> +CONFIG_LEAF_DIR ?= sysconfig
>> +To add support for new distributions that don't use the above locations,
>> +one must grep for the above elements and add appropriate checks.
> Surely this should simply say that for a new distro one must change
> the settings for the appropriate values, in Config.mk, and/or set them
> in a local ".config" file.  There shouldn't be any need to grep for
> them, should there ?

Yes and no. For building one only needs to add these in the env or Config.mk,
but for runtime, xen checks each location in turn and for non-standard
checks need to be added. eg:

If someone adds CONFIG_LEAF_DIR=blah, then they will need to modify the
if statement below as well.

if [ -f /etc/sysconfig/xenballoon.conf ]; then
+       . /etc/sysconfig/xenballoon.conf
+elif [ -f /etc/default/xenballoon.conf ]; then
+       . /etc/default/xenballoon.conf

I felt that if I left a tag in all these places, like "distro_mapping"
or something
similar it would give people something to search for to find all the places they
needed to add new code.

>> -080630 modifications to support SUSE-based and debian-based guests
>> +080630 modifications to support SUSE-based
> This can be removed now ?

Oh, right, I guess this does handle the SUSE case too. - will do.

Thanks for all the hints.


> Ian.

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>