Re: [Xen-devel] [patch] Xen build - Debian vs Redhat layout patch options

[Bruce Edge <bruce.edge@xxxxxxxxx>]

On Fri, Sep 17, 2010 at 9:11 AM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> Bruce Edge writes ("Re: [Xen-devel] [patch] Xen build - Debian vs Redhat 
> layout patch options"):
>> OK, resubmit #3 with Olaf's suggestion.
>> No other changes.
>
> Thanks.  Nearly there I think...
>
> There are still a couple of occurrences of this:
>
>> +# See DISTRO_TYPE in the docs

OK, will fix. It changed so many times I forgot about them...

>
> which should presumably refer to docs/misc/distro_mapping.txt.
>
>
>> +CONFIG_LEAF_DIR  | /sysconfig       | /default      | /sysconfig     |
>                      ^                  ^               ^
>
> Not hugely important, but these slashes should be omitted I think ?

Yes, they can and will in the next round.

> Since CONFIG_LEAF_DIR is used and defined like this:
>
>> +SYSCONFIG_DIR = $(CONFIG_DIR)/$(CONFIG_LEAF_DIR)
> ...
>> +CONFIG_LEAF_DIR ?= sysconfig
>
>
>> +To add support for new distributions that don't use the above locations,
>> +one must grep for the above elements and add appropriate checks.
>
> Surely this should simply say that for a new distro one must change
> the settings for the appropriate values, in Config.mk, and/or set them
> in a local ".config" file.  There shouldn't be any need to grep for
> them, should there ?

Yes and no. For building one only needs to add these in the env or Config.mk,
but for runtime, xen checks each location in turn and for non-standard
locations
checks need to be added. eg:

If someone adds CONFIG_LEAF_DIR=blah, then they will need to modify the
if statement below as well.

if [ -f /etc/sysconfig/xenballoon.conf ]; then
+       . /etc/sysconfig/xenballoon.conf
+elif [ -f /etc/default/xenballoon.conf ]; then
+       . /etc/default/xenballoon.conf
+fi

I felt that if I left a tag in all these places, like "distro_mapping"
or something
similar it would give people something to search for to find all the places they
needed to add new code.

>
>
>> -080630 modifications to support SUSE-based and debian-based guests
>> +080630 modifications to support SUSE-based
>
> This can be removed now ?

Oh, right, I guess this does handle the SUSE case too. - will do.

Thanks for all the hints.

-Bruce

>
> Ian.
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel