This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [patch] Xen build - Debian vs Redhat layout patch option

To: Bruce Edge <bruce.edge@xxxxxxxxx>
Subject: Re: [Xen-devel] [patch] Xen build - Debian vs Redhat layout patch options
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Fri, 17 Sep 2010 17:11:26 +0100
Cc: Olaf Hering <olaf@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 17 Sep 2010 09:12:25 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <AANLkTimJCnnZDTY5tRep1ERj50rphWBXF+iT3bDR6eVQ@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.DEB.2.00.1007071207480.17029@kaball-desktop> <AANLkTi=2TveuUANkar9d89k_Ck22RWFDEB-bKnCanOuz@xxxxxxxxxxxxxx> <19599.43888.826450.690087@xxxxxxxxxxxxxxxxxxxxxxxx> <AANLkTik8b2evzTg8biVPVySvJTzVYmTSmSSt-WhbYrnD@xxxxxxxxxxxxxx> <19600.39408.486631.15438@xxxxxxxxxxxxxxxxxxxxxxxx> <AANLkTim8TGttxjWiVCnXrh9wyzpfaC6sd=MirvYUw__y@xxxxxxxxxxxxxx> <19602.17927.197275.274485@xxxxxxxxxxxxxxxxxxxxxxxx> <AANLkTi=vgZJZz+xbfgXNok6yvqTPh5xTDGS-OQ7VKW36@xxxxxxxxxxxxxx> <20100916204517.GA9380@xxxxxxxxx> <AANLkTi=S6ZL=1L9iX7W7JyRVMTWOS-GCO=wLoVr4CpC0@xxxxxxxxxxxxxx> <20100916205913.GA11392@xxxxxxxxx> <AANLkTimJCnnZDTY5tRep1ERj50rphWBXF+iT3bDR6eVQ@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Bruce Edge writes ("Re: [Xen-devel] [patch] Xen build - Debian vs Redhat layout 
patch options"):
> OK, resubmit #3 with Olaf's suggestion.
> No other changes.

Thanks.  Nearly there I think...

There are still a couple of occurrences of this:

> +# See DISTRO_TYPE in the docs

which should presumably refer to docs/misc/distro_mapping.txt.

> +CONFIG_LEAF_DIR  | /sysconfig       | /default      | /sysconfig     |
                      ^                  ^               ^

Not hugely important, but these slashes should be omitted I think ?
Since CONFIG_LEAF_DIR is used and defined like this:

> +CONFIG_LEAF_DIR ?= sysconfig

> +To add support for new distributions that don't use the above locations,
> +one must grep for the above elements and add appropriate checks.

Surely this should simply say that for a new distro one must change
the settings for the appropriate values, in Config.mk, and/or set them
in a local ".config" file.  There shouldn't be any need to grep for
them, should there ?

> -080630 modifications to support SUSE-based and debian-based guests
> +080630 modifications to support SUSE-based

This can be removed now ?


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>