This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] PATCH: Remove execute permission from xend-debug.log

To: Aron Griffis <aron@xxxxxx>
Subject: Re: [Xen-devel] PATCH: Remove execute permission from xend-debug.log
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 24 Apr 2007 23:30:30 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Delivery-date: Tue, 24 Apr 2007 15:27:36 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070424221556.GG2018@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AceGwCoCaKOeU/KzEduh1gAWy6hiGQ==
Thread-topic: [Xen-devel] PATCH: Remove execute permission from xend-debug.log
User-agent: Microsoft-Entourage/
On 24/4/07 23:15, "Aron Griffis" <aron@xxxxxx> wrote:

>>> Seems that the patch should be using 0666 instead of 0600 so that
>>> umask can affect group/other perms.  At the very least it should use
>>> 0664.
>> Xen-debug.log is the only file in /var/log/xen getting created with
>> +x permissions, so something is obviously up. Arguably we can get
>> rid of xend-debug.log entirely -- I don't believe anything ever gets
>> logged there these days. I took the patch because 0600 seems saner
>> than 0755.
> It doesn't make any real difference to me, just thought I'd bring up
> the umask question before the patch was committed... though at this
> point it's in staging, so I guess I was too late. ;-)

You're probably right that one of 0644,0664,0666 is better. They're
certainly more in line with all other files under /var/log/xen.

 -- Keir

Xen-devel mailing list