This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] PATCH: Remove execute permission from xend-debug.log

To: Keir Fraser <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] PATCH: Remove execute permission from xend-debug.log
From: Aron Griffis <aron@xxxxxx>
Date: Tue, 24 Apr 2007 18:15:56 -0400
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Delivery-date: Tue, 24 Apr 2007 15:14:36 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C2543E60.63B0%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Keir Fraser <keir@xxxxxxxxxxxxx>, "Daniel P. Berrange" <berrange@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
References: <20070424214524.GF2018@xxxxxxxxx> <C2543E60.63B0%keir@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.13 (2006-08-11)
Keir Fraser wrote:  [Tue Apr 24 2007, 06:08:16PM EDT]
> On 24/4/07 22:45, "Aron Griffis" <aron@xxxxxx> wrote:
> >>> The file /var/log/xen/xend-debug.log is currently being created with
> >>> executable permission bits set. This is because the os.open() method
> >>> defaults to using a mode of 0777 if no third parameter is provided.
> >>> The attached patch changes the mode to 0600 to ensure that the file
> >>> permissions come out as -rw-------  instead of -rwxr-xr-x
> >> 
> >> Doesn't os.open default to 0777 & ~umask?  Doesn't seem like xend
> >> should be overriding root's umask
> > 
> > Seems that the patch should be using 0666 instead of 0600 so that
> > umask can affect group/other perms.  At the very least it should use
> > 0664.
> Xen-debug.log is the only file in /var/log/xen getting created with
> +x permissions, so something is obviously up. Arguably we can get
> rid of xend-debug.log entirely -- I don't believe anything ever gets
> logged there these days. I took the patch because 0600 seems saner
> than 0755.

It doesn't make any real difference to me, just thought I'd bring up
the umask question before the patch was committed... though at this
point it's in staging, so I guess I was too late. ;-)


Xen-devel mailing list