This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] PATCH: Remove execute permission from xend-debug.log

To: "Daniel P. Berrange" <berrange@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] PATCH: Remove execute permission from xend-debug.log
From: Aron Griffis <aron@xxxxxx>
Date: Tue, 24 Apr 2007 17:45:24 -0400
Delivery-date: Tue, 24 Apr 2007 14:44:02 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070424213941.GE2018@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: "Daniel P. Berrange" <berrange@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
References: <20070424192211.GJ30877@xxxxxxxxxx> <20070424213941.GE2018@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.13 (2006-08-11)
Aron Griffis wrote:  [Tue Apr 24 2007, 05:39:41PM EDT]
> Daniel P. Berrange wrote:  [Tue Apr 24 2007, 03:22:11PM EDT]
> > The file /var/log/xen/xend-debug.log is currently being created with 
> > executable permission bits set. This is because the os.open() method
> > defaults to using a mode of 0777 if no third parameter is provided.
> > The attached patch changes the mode to 0600 to ensure that the file
> > permissions come out as -rw-------  instead of -rwxr-xr-x
> Doesn't os.open default to 0777 & ~umask?  Doesn't seem like xend
> should be overriding root's umask

Seems that the patch should be using 0666 instead of 0600 so that
umask can affect group/other perms.  At the very least it should use


Xen-devel mailing list