WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] PATCH: Remove execute permission from xend-debug.log

To: Aron Griffis <aron@xxxxxx>, "Daniel P. Berrange" <berrange@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] PATCH: Remove execute permission from xend-debug.log
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Tue, 24 Apr 2007 23:08:16 +0100
Delivery-date: Tue, 24 Apr 2007 15:05:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070424214524.GF2018@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AceGvQ7iTV9XoPKwEduiCgAWy6hiGQ==
Thread-topic: [Xen-devel] PATCH: Remove execute permission from xend-debug.log
User-agent: Microsoft-Entourage/11.3.3.061214
On 24/4/07 22:45, "Aron Griffis" <aron@xxxxxx> wrote:

>>> The file /var/log/xen/xend-debug.log is currently being created with
>>> executable permission bits set. This is because the os.open() method
>>> defaults to using a mode of 0777 if no third parameter is provided.
>>> The attached patch changes the mode to 0600 to ensure that the file
>>> permissions come out as -rw-------  instead of -rwxr-xr-x
>> 
>> Doesn't os.open default to 0777 & ~umask?  Doesn't seem like xend
>> should be overriding root's umask
> 
> Seems that the patch should be using 0666 instead of 0600 so that
> umask can affect group/other perms.  At the very least it should use
> 0664.

Xen-debug.log is the only file in /var/log/xen getting created with +x
permissions, so something is obviously up. Arguably we can get rid of
xend-debug.log entirely -- I don't believe anything ever gets logged there
these days. I took the patch because 0600 seems saner than 0755.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel