This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH][LINUX] use machine_emergency_restart() from the

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][LINUX] use machine_emergency_restart() from the generic header.
From: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
Date: Tue, 8 Aug 2006 07:49:35 -0400
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 08 Aug 2006 04:50:04 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C0FE0E08.A08%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C0FE0E08.A08%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
First, I apologize for not seeing the link error.

On Aug 8, 2006, at 4:46 AM, Keir Fraser wrote:

On 7/8/06 6:20 pm, "Jimi Xenidis" <jimix@xxxxxxxxxxxxxx> wrote:

This patch uses the standard generic header for the definition of
machine_emergency_restart() and reverses the call path for XenoLinux.

It doesn't reverse the call path, it removes machine_emergency_restart() entirely from drivers/xen/core/reboot.c. Hence the kernel no longer builds.

  static inline void machine_emergency_restart(void)

But asm-i386 has a def that is not the same.
If fact all arch's accept for i386 and x86_64 define it like:


  #include <asm-generic/emergency-restart.h>


What is wrong with the code as it is? It follows the call order of the
arch-specific reboot.c (e.g., arch/i386/kernel/reboot.c).

I have a linker problem building this file in POWERPC as you may suspect. The ./driver/xen/ file is more like the other archs than x86, and should be more portable.

Not sure what header magik would be needed here, if you think its worthwhile I'll pursue it.


Xen-devel mailing list