WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][LINUX] use machine_emergency_restart() from the

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][LINUX] use machine_emergency_restart() from the generic header.
From: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
Date: Tue, 8 Aug 2006 08:46:23 -0400
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 08 Aug 2006 05:47:00 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C0FE4190.A24%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C0FE4190.A24%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On Aug 8, 2006, at 8:26 AM, Keir Fraser wrote:


On 8/8/06 12:49 pm, "Jimi Xenidis" <jimix@xxxxxxxxxxxxxx> wrote:

I have a linker problem building this file in POWERPC as you may
suspect.
The ./driver/xen/ file is more like the other archs than x86, and
should be more portable.

Not sure what header magik would be needed here, if you think its
worthwhile I'll pursue it.

You could switch the call order in drivers/xen/core/reboot.c so that
machine_emergency_restart calls machine_restart, and then conditionally
compile the former only for x86. Not super nice but it's at least
straightforward. I'd take a patch that did that.

hmm, there are a lot of x86 isms in this file.. I think having all these ifdefs in ./drivers will be problematic to the Linux integration cause.
At some point I could see us trying to remove/abstract them anyway.

Perhaps we could prefix all the methods with "xen_" and have arch specific code _in_ arch specific directories call it accordingly?

I would also like to separate the suspend code from the reboot/halt code into different files since thats is cleaner to select that support by CONFIG_, thoughts?

-JX

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel