 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH][LINUX] use machine_emergency_restart() from the
| To: | Jimi Xenidis <jimix@xxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH][LINUX] use machine_emergency_restart() from the generic header. |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Tue, 08 Aug 2006 13:54:16 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Tue, 08 Aug 2006 05:54:42 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <64B111CB-2A1E-4C69-B85B-01CD8F41B121@xxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Aca66cFP/7uvxibcEduaRAAKle7CWA== |
| Thread-topic: | [Xen-devel] [PATCH][LINUX] use machine_emergency_restart() from the generic header. |
| User-agent: | Microsoft-Entourage/11.2.5.060620 |
On 8/8/06 1:46 pm, "Jimi Xenidis" <jimix@xxxxxxxxxxxxxx> wrote: > hmm, there are a lot of x86 isms in this file.. I think having all > these ifdefs in ./drivers will be problematic to the Linux > integration cause. > At some point I could see us trying to remove/abstract them anyway. > > Perhaps we could prefix all the methods with "xen_" and have arch > specific code _in_ arch specific directories call it accordingly? > > I would also like to separate the suspend code from the reboot/halt > code into different files since thats is cleaner to select that > support by CONFIG_, thoughts? All sound like good suggestions. It'll be necessary for upstream merging anyway, as it'll need to hook under arch-specific paravirt_ops. I'd take patches to split into separate source files, certainly. And the xen_ prefixing probably too. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH][LINUX] use machine_emergency_restart() from the generic header., Jimi Xenidis |
|---|---|
| Next by Date: | [Xen-devel] Re: Communicating with the domU from dom0 without Network, Mike D. Day |
| Previous by Thread: | Re: [Xen-devel] [PATCH][LINUX] use machine_emergency_restart() from the generic header., Jimi Xenidis |
| Next by Thread: | [Xen-devel] [PATCH][LINUX] use machine_emergency_restart() from the, Jimi Xenidis |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
