This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH][RESEND] Porting Mini-OS to ia64

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH][RESEND] Porting Mini-OS to ia64
From: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 8 Aug 2006 13:36:27 +0200
Cc: Grzegorz Milos <gm281@xxxxxxxxx>
Delivery-date: Tue, 08 Aug 2006 04:37:04 -0700
Domainkey-signature: s=s768; d=fujitsu-siemens.com; c=nofws; q=dns; b=TGTHpuNIOY28Saw5n81uG4zMzC+8x21362vggCQys+k1v7qmR0q0NcWIvKQUPsYMtMoZU3hZ+P0AndOqwCtnKvj+fc2tXqzgoB+ZlA8a8DksNUplmIIb3MUlFSHgyPdL;
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <44D73721.2080008@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200608010828.18481.dietmar.hahn@xxxxxxxxxxxxxxxxxxx> <200608031424.18010.dietmar.hahn@xxxxxxxxxxxxxxxxxxx> <44D73721.2080008@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.3
Am Montag, 7. August 2006 14:50 schrieb Grzegorz Milos:
> >> With respect to your patch. I would prefer to see the following
> >> directory structure:
> >> mini-os/include/x86
> >> mini-os/include/x86/x86_32
> >> mini-os/include/x86/x86_64
> >> If we find that there is only one file in x86_32/x86_64 it would be
> >> better to scrap the two directories and put the files in x86.
> >>
> >> Continuing, architecture dependent .c files should end up in:
> >> mini-os/arch/x86
> >> mini-os/arch/x86/x86_32
> >> mini-os/arch/x86/x86_64
> >
> > I moved only few files and changed the Makefile. In the next step I will
> > look into the files for special defines for x86_32 and x86_64.
> > I hope this patch is ok now.
> The patch still introduces
> mini-os/include/x86_32 and mini-os/include/x86_64.
Sorry I overlooked the right directory hierarchy.

> I would prefer both x86_32 and x86_64 to be subdirectories of
> mini-os/include/x86.
I hope, now it's correct!

> Also, I would replace "=" with "+=" when you assign to EXTRA_INC/SRC in
> mini-os/Makefile.
OK I did this.
I also added some lines for creating architecture dependent links.
Maybe there are some discussion points about the rules I added.

> Cheers
> Gregor
Thanks for understanding.


Attachment: mini-os.patch
Description: Text Data

Xen-devel mailing list