WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH 12 of 20] Add APIs to switch n1/n2 VMCS

To: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH 12 of 20] Add APIs to switch n1/n2 VMCS
From: "Dong, Eddie" <eddie.dong@xxxxxxxxx>
Date: Fri, 3 Jun 2011 15:30:39 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Dong, Eddie" <eddie.dong@xxxxxxxxx>
Delivery-date: Fri, 03 Jun 2011 00:32:34 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110602145002.GK5098@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1307005033@xxxxxxxxxxxxxxxxxxxx> <62cc6c7516e010ef673c.1307005045@xxxxxxxxxxxxxxxxxxxx> <20110602145002.GK5098@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcwhNGcGtHT8hEoAS1aySQBUWi+5UAAi7OIQ
Thread-topic: [Xen-devel] [PATCH 12 of 20] Add APIs to switch n1/n2 VMCS
> > +    /* no foreign access */
> > +    if ( unlikely(v != current) )
> > +        return;
> > +
> > +    if ( unlikely(current->arch.hvm_vmx.vmcs != from) )
> > +        return;
> 
> Do you really want this function to fail silently if called with v !=
> current?  Use ASSERT(), or, even better, remove the first argument
> entirely.
> 
Deleted.

Thx, Eddie

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>