Re: [Xen-devel] [PATCH 20 of 20] n2 MSR handling and capability

To:	Tim Deegan <Tim.Deegan@xxxxxxxxxx>, Eddie Dong <eddie.dong@xxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH 20 of 20] n2 MSR handling and capability exposure
From:	Keir Fraser <keir.xen@xxxxxxxxx>
Date:	Thu, 02 Jun 2011 20:20:06 +0100
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Thu, 02 Jun 2011 12:21:11 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:cc:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=yEVvgS7TN5TURjchT28KRdzOASJrMZrtrJI/g8S5yB0=; b=ZhcE+pEVtKSggeMWeCiWc8JXHSeykppwDBVyNSWdFtu+ev3HW3PBi7E0ec4UzTaGVr 1MacFuNXvwa+sV4T5AxNICzLEXO0grOMBbYgcXZktFgq8Lx4FWQEZvLBgdMMA+MmS1Wy lsU0lgZc0cPnmIC7glZp5aBU47KBG6cshgwlA=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=TvyZX91jRaAUdYj3qnmU1geo6zJoVN1VIl3bcI00i/VhZNACkzi58wUXOAnwpE8AR2 Y+M+p4RuibDpxYt+mZrR3k/JBn8jqabMRhjWhRcFidEqmSwHP2yGROAbg7poTFALqJua LY2l2OTpfczvZmU1PAPfkDv1w1TBgFL3q9JXc=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<20110602151128.GQ5098@xxxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcwhWhRns2/Jr6rGJEGrbV1iF/Kx4g==
Thread-topic:	[Xen-devel] [PATCH 20 of 20] n2 MSR handling and capability exposure
User-agent:	Microsoft-Entourage/12.29.0.110113

On 02/06/2011 16:11, "Tim Deegan" <Tim.Deegan@xxxxxxxxxx> wrote:

>> BTW, I don't really like defining all these REMOVED_* macros, each
>> of which is used only once a few lines from the definition (here and
>> elsewhere in the series).  It just adds clutter for no benefit.
>> 
> 
> Oh, I forgot to say: will this feature-blacklisting work over live
> migration to a machine with a different CPU?  There isn't an equivalnet
> of the CPUID masking feature to make all the machines in a cluster seem
> to have the same VMX features.
> 
> Elsewhere we use whitelisting for passsing hardware capability flags to
> HVM guests; I think we should use whitelists here too.

Blacklists create a total mess of doom. We should absolutely disallow the
creation of any new ones. I think HVM guests are currently clean in this
regard and should stay that way.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH 20 of 20] n2 MSR handling and capability exposure