WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH 15 of 20] Switch shadow/virtual VMCS between n1/n

To: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH 15 of 20] Switch shadow/virtual VMCS between n1/n2 guests
From: "Dong, Eddie" <eddie.dong@xxxxxxxxx>
Date: Fri, 3 Jun 2011 15:57:52 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Dong, Eddie" <eddie.dong@xxxxxxxxx>
Delivery-date: Fri, 03 Jun 2011 01:02:45 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110602145623.GL5098@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1307005033@xxxxxxxxxxxxxxxxxxxx> <bd15acfc9b822ccf27b5.1307005048@xxxxxxxxxxxxxxxxxxxx> <20110602145623.GL5098@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcwhNUQFQchxiAKER6mwlZ4Re4oJ3wAi7mug
Thread-topic: [Xen-devel] [PATCH 15 of 20] Switch shadow/virtual VMCS between n1/n2 guests
> > +    u32 shadow_cntrl;
> > +    struct nestedvcpu *nvcpu = &vcpu_nestedhvm(v);
> > +
> > +#define REMOVED_EXIT_CONTROL_BITS    ((1<<2) |           \
> 
> Define a macro for whatever 1<<2 means here, please.
> 

Done.

> > +                (VM_EXIT_SAVE_GUEST_PAT) |               \
> > +                (VM_EXIT_SAVE_GUEST_EFER) |              \
> > +                (VM_EXIT_SAVE_PREEMPT_TIMER))
> > +    shadow_cntrl = __get_vvmcs(nvcpu->nv_vvmcx,
> VM_EXIT_CONTROLS);
> > +    shadow_cntrl &= ~REMOVED_EXIT_CONTROL_BITS;
> > +    shadow_cntrl |= host_cntrl;
> > +    __vmwrite(VM_EXIT_CONTROLS, shadow_cntrl);
> > +}



> > +    /* SDM 20.6.6: L2 guest execution may change GUEST CR0/CR4 */
> > +    mask = __get_vvmcs(vvmcs, CR0_GUEST_HOST_MASK);
> > +    if ( ~mask )
> > +    {
> > +        cr = __get_vvmcs(vvmcs, GUEST_CR0);
> > +        cr = (cr & mask) | (__vmread(GUEST_CR4) & ~mask);
> 
> Cut-n-paste error?                      ^^^^^^^^^
> 
Oh, Yes, Thanks.
Eddie

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>