Re: [Xen-devel] Re: [patch] final header fixes

On Thursday 24 March 2005 14:40, Dan Magenheimer wrote:
> This second patch looks good to me, though I would prefer
> to change to '#include <asm/regs.h>' from 'struct xen_regs;'
> as xen_regs is #define'd to pt_regs on ia64 and the explicit
> use of struct xen_regs in a header could cause header ordering
> problems later.  Will that work for ppc?

Ah, sure... I was just trying to avoid extra dependency trees where possible. 
Apparently it is not possible here. :)

So that should be #include <public/xen.h> (which includes arch-*.h which 
defines xen_regs). It looks like we may want to move ia64's #define to 
arch-ia64.h ...

-- 
Hollis Blanchard
IBM Linux Technology Center


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:	[Xen-devel] hanging dell hardware, michal urbanski
Next by Date:	RE: [Xen-devel] Re: [patch] final header fixes, Magenheimer, Dan (HP Labs Fort Collins)
Previous by Thread:	[Xen-devel] Re: [patch] final header fixes, Dan Magenheimer
Next by Thread:	Re: [Xen-devel] Re: [patch] final header fixes, Christian Limpach
Indexes:	[Date] [Thread] [Top] [All Lists]