This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [patch] final header fixes

On Thu, 2005-03-24 at 21:24 +0000, Christian Limpach wrote:
> On Thu, 24 Mar 2005 15:03:19 -0600, Hollis Blanchard <hollisb@xxxxxxxxxx> 
> wrote:
> > On Thursday 24 March 2005 14:40, Dan Magenheimer wrote:
> > > This second patch looks good to me, though I would prefer
> > > to change to '#include <asm/regs.h>' from 'struct xen_regs;'
> > > as xen_regs is #define'd to pt_regs on ia64 and the explicit
> > > use of struct xen_regs in a header could cause header ordering
> > > problems later.  Will that work for ppc?
> > 
> > Ah, sure... I was just trying to avoid extra dependency trees where 
> > possible.
> > Apparently it is not possible here. :)
> > 
> > So that should be #include <public/xen.h> (which includes arch-*.h which
> > defines xen_regs). It looks like we may want to move ia64's #define to
> > arch-ia64.h ...
> Could you please include asm/regs.h or public/xen.h wherever you want
> to include keyhandler.h?  Thanks.

That works great, until somebody other than me includes or modifies
keyhandler.h (or any of the other headers we've been talking about).

I guess I don't see the difficulty in making sure you include what you

Hollis Blanchard
IBM Linux Technology Center

SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
Xen-devel mailing list