 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] Re: [patch] final header fixes
| To: | Hollis Blanchard <hollisb@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] Re: [patch] final header fixes |
| From: | Christian Limpach <christian.limpach@xxxxxxxxx> |
| Date: | Thu, 24 Mar 2005 21:24:26 +0000 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxxxx, Dan Magenheimer <dan.magenheimer@xxxxxx> |
| Delivery-date: | Thu, 24 Mar 2005 21:25:45 +0000 |
| Domainkey-signature: | a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=UnTZSQr4EKNNVGXoCF1XHAm04K9/K2bE/3f5q++YxYCiMLxrzax4frbpnhBp3Mvre0t5NdcG67IEVEMJ/waPRESRnFjGIHRNPIbyZrss4hQrgIPp04+B3jv+lOe6WSJ33zAWb5Q5+MFdFFw+w8wgxlBn2Ws5hCrUvFgEVIPv3+E= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <200503241503.19423.hollisb@xxxxxxxxxx> |
| List-archive: | <http://sourceforge.net/mailarchive/forum.php?forum=xen-devel> |
| List-help: | <mailto:xen-devel-request@lists.sourceforge.net?subject=help> |
| List-id: | List for Xen developers <xen-devel.lists.sourceforge.net> |
| List-post: | <mailto:xen-devel@lists.sourceforge.net> |
| List-subscribe: | <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=subscribe> |
| List-unsubscribe: | <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=unsubscribe> |
| References: | <200503231601.02096.hollisb@xxxxxxxxxx> <cdb25e531e93bff0f2bd375ef5fe3be7@xxxxxxxxxx> <loom.20050324T213615-309@xxxxxxxxxxxxxx> <200503241503.19423.hollisb@xxxxxxxxxx> |
| Reply-to: | Christian.Limpach@xxxxxxxxxxxx |
| Sender: | xen-devel-admin@xxxxxxxxxxxxxxxxxxxxx |
On Thu, 24 Mar 2005 15:03:19 -0600, Hollis Blanchard <hollisb@xxxxxxxxxx> wrote:
> On Thursday 24 March 2005 14:40, Dan Magenheimer wrote:
> > This second patch looks good to me, though I would prefer
> > to change to '#include <asm/regs.h>' from 'struct xen_regs;'
> > as xen_regs is #define'd to pt_regs on ia64 and the explicit
> > use of struct xen_regs in a header could cause header ordering
> > problems later. Will that work for ppc?
>
> Ah, sure... I was just trying to avoid extra dependency trees where possible.
> Apparently it is not possible here. :)
>
> So that should be #include <public/xen.h> (which includes arch-*.h which
> defines xen_regs). It looks like we may want to move ia64's #define to
> arch-ia64.h ...
Could you please include asm/regs.h or public/xen.h wherever you want
to include keyhandler.h? Thanks.
christian
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [patch] small accounting and lockup fix for xenfreebsd on -unstable, Kip Macy |
|---|---|
| Next by Date: | [Xen-devel] [Q] eth0 not up on dom0, Bharadwaj Yadavalli |
| Previous by Thread: | Re: [Xen-devel] Re: [patch] final header fixes, Hollis Blanchard |
| Next by Thread: | Re: [Xen-devel] Re: [patch] final header fixes, Hollis Blanchard |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
