Re: [Xen-devel] [patch/unstable] page table cleanups

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 14 Mar 2005, at 12:07, Gerd Knorr wrote:

> In many places xen uses "unsigned long" instead of the l*_pgentry_t
> types to pass around page table entries.  Here is a patch which fixes
> this in a number of places (mostly in shadow mode code).  Thats what
> I've trapped in so far, maybe more of these patches follow.
>
> Fixing this is needed for adding PAE support to xen.  In PAE paging 
> mode
> the page table entries are 64 bit and thus will not fit into "unsigned
> long".
This is certainly one way to go. The other is to change those unsigned 
longs into a physaddr_t which is u64 on 32-bit PAE systems. I'm not 
fussed too much which way we go, but Ian has pointed out that the 
l*_pgentry_t types haven't actually found us any bugs (although I might 
argue that it has prevented any bugs ever getting as far as the master 
repository :-) ).
We'll need a physaddr_t (or machaddr_t?) in some places in any case -- 
as a parameter to map_domain_mem(), for example.
 -- Keir



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-devel