This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [patch/unstable] page table cleanups

To: Gerd Knorr <kraxel@xxxxxxxxxxx>
Subject: Re: [Xen-devel] [patch/unstable] page table cleanups
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 14 Mar 2005 12:49:23 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 14 Mar 2005 12:47:47 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20050314120731.GA11829@bytesex>
List-archive: <http://sourceforge.net/mailarchive/forum.php?forum=xen-devel>
List-help: <mailto:xen-devel-request@lists.sourceforge.net?subject=help>
List-id: List for Xen developers <xen-devel.lists.sourceforge.net>
List-post: <mailto:xen-devel@lists.sourceforge.net>
List-subscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=subscribe>
List-unsubscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=unsubscribe>
References: <20050314120731.GA11829@bytesex>
Sender: xen-devel-admin@xxxxxxxxxxxxxxxxxxxxx

On 14 Mar 2005, at 12:07, Gerd Knorr wrote:

In many places xen uses "unsigned long" instead of the l*_pgentry_t
types to pass around page table entries.  Here is a patch which fixes
this in a number of places (mostly in shadow mode code).  Thats what
I've trapped in so far, maybe more of these patches follow.

Fixing this is needed for adding PAE support to xen. In PAE paging mode
the page table entries are 64 bit and thus will not fit into "unsigned

This is certainly one way to go. The other is to change those unsigned longs into a physaddr_t which is u64 on 32-bit PAE systems. I'm not fussed too much which way we go, but Ian has pointed out that the l*_pgentry_t types haven't actually found us any bugs (although I might argue that it has prevented any bugs ever getting as far as the master repository :-) ).

We'll need a physaddr_t (or machaddr_t?) in some places in any case -- as a parameter to map_domain_mem(), for example.

 -- Keir

SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
Xen-devel mailing list