This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [patch/unstable] page table cleanups

To: "Gerd Knorr" <kraxel@xxxxxxxxxxx>, "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: RE: [Xen-devel] [patch/unstable] page table cleanups
From: "Ian Pratt" <m+Ian.Pratt@xxxxxxxxxxxx>
Date: Mon, 14 Mar 2005 14:00:30 -0000
Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxxx>, <ian.pratt@xxxxxxxxxxxx>
Delivery-date: Mon, 14 Mar 2005 14:01:10 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-archive: <http://sourceforge.net/mailarchive/forum.php?forum=xen-devel>
List-help: <mailto:xen-devel-request@lists.sourceforge.net?subject=help>
List-id: List for Xen developers <xen-devel.lists.sourceforge.net>
List-post: <mailto:xen-devel@lists.sourceforge.net>
List-subscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=subscribe>
List-unsubscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=unsubscribe>
Sender: xen-devel-admin@xxxxxxxxxxxxxxxxxxxxx
Thread-index: AcUonD0dGh3vExYcSBCSWc+YQrY+NQAAH3MA
Thread-topic: [Xen-devel] [patch/unstable] page table cleanups
 > > I'm not fussed too much which way we go, but Ian has 
> pointed out that
> > the l*_pgentry_t types haven't actually found us any bugs 
> (although I
> > might argue that it has prevented any bugs ever getting as 
> far as the
> > master repository :-) ).
> I'd argue that way as well.  The whole point of the "typedef 
> { u{32|64}
> l? } l?_pgentry_t" types and the access macros is to make the 
> _compiler_
> notice bugs, so they can't creep into the code base in the first place
> because gcc refuses to compile the buggy code ;)

I guess I'd prefer to have it be a scalar type because all the accessor
macros actually do a pretty good job of obfusticating the code -- you
see mk_( _val( X ) [logical op]) all over the place. One way to fix this
would be to have a better accessor macro for performing logical ops on
the flags field of a pgentry.


SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
Xen-devel mailing list