[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v v2 1/7] x86: Remove x86 prefixed names from mcheck code
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Kevin Lampis <kevin.lampis@xxxxxxxxxx>
- Date: Fri, 13 Mar 2026 13:51:36 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sBMjWIV5DbwwQRt9PenOijdXap2/xcZHjGWEN0gQWlA=; b=OfQ0qpk4pn+r9Su9SL+pRoIu0O0KvabK65iemmB0N6EnIZKETETiLP7zG5MAVpPe+3DWFVHH+wgY8830JqJwye4tPCsSihwX9X6MCCtMTXYVAFlTvp+C5p9/vaBB01aJRiPeEY0wrWYmsPvfPjVp+sHtoFlOAoHf58Tfp8CIimTNpqn+Iko4eDuOAyyWmYPVY65kqlI+m3a9m1iGMqSuuKNXKU3edlFge++/SZ/Pnjey1zxpBnqZlkx9HMfIgB5EJ3qynZWyL9O6laZkKdtlgFOLWOEhFq/gh+4NO0KYmVvegpWaVKQFkj/19nTN9pt+nos+QHp2FIpbtOmNB7IHqw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=w9iJ1M+40aHljvlBqqx0bR1ngDhoDJwUs1shxrUEszYYcmdN3ZmF1L7AuTmY7xku5eA0WFKT14RucgseZBXUga/HESoNk5CnI/yvK9eOgsK0T/aO890B7OaCEhoIcXl485H8vfW1cjR5IFazpwIXAvGfUg4msf/39xrsIrQ9Ad3kwLZE36psztLmKoePJkHrsSIbwF/BIhTYtMfGxsDHSP14OVjIGCrqyTe82T3WafAwm0fqMwgNCxj3s/COOml45eOQZh6PSzsHqm/u6pS5TvVzp4vdV2ZveJuxDXU0WbXhU7mjHneIONwJXboQ3KHbqlANRppvqmYyZcYzWJxAdA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Fri, 13 Mar 2026 13:51:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels:
- Thread-index: AQHcsmDsLyrsERR4wkGR6TwdeRLYp7WrlD6AgADkKjA=
- Thread-topic: [PATCH v v2 1/7] x86: Remove x86 prefixed names from mcheck code
>> - if ( c->x86_vendor == X86_VENDOR_INTEL && c->x86 == 6 &&
>> - c->x86_model >= 0xe )
>> - return true;
>> - return false;
>> + return c->vendor == X86_VENDOR_INTEL && c->vfm >= INTEL_CORE_YONAH;
>> }
>
>This breaks P4.
>
>It is not safe to write expressions like this, and I've already
>explained why.
Last time you said it's not safe to drop the `vendor == X86_VENDOR_INTEL`
part because `vmf >= ...` by itself will pull in other vendors. Sorry, I should
have realised the same logic applies to the family field too.
This "breaks P4" because Pentium 4 NetBurst is family 15 and will now match
this new `vfm >= ...` expression when it didn't before.
I'll take Jan's suggestion below to match `vendor == Intel` and `family != 15`.
|
