[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v v2 1/7] x86: Remove x86 prefixed names from mcheck code
- To: Kevin Lampis <kevin.lampis@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 13 Mar 2026 00:01:11 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cWYMl+9F6/FUqWqvRpyhGOMiN+6iTBhV64lLKmpc+zk=; b=SeMittNCBlhvYUSjFuhYCNpjL4A8KwkmAe1O31nFOzGLzdETGJkiSf/gKgU71Eobr2fRHsdsqNLHTcvGnw5g//lWstzOrpHvr9ZZ2w5Wq2T+L85p3G20UiQBiDWA6I7yknO37bgjkRJz082mbUnnNcc1drSZA1EEEpDymzFbj8YUovYYYndTggXjXnPQCWUXMSnnS3ZNPKNMnMx3W1/zaIvq9OB/GGCRji8I9NkafHPSBK4otOnORE1665uRzfwrYiw57XYhspXrR/PBgoXPWDX2vTcVR0XU6ZPUR5QsfpT0bfdCmpKI/D9BzMGSMc0O8vOyaKIY1LHHcK1M8RBCZA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DAundYrdPnch3CbjKMhGVBb6DoymJKFWvqYtNobuYsvtXsgcwBU+WscgprqvmeciYzFYZanr96oH9YgnV3cpAjNltP6t77Nq2jERQTcS/p7rfhzFIlUDPapclnixb84gxUw0kXrp66un0VPXfRfp+g3RfhHBI6eQBxV6xWYZSVbKXz1qDcs+F2Kt717gNre/SRsKLCJd+u3PQJdbRD31Ahkq4ulKahZ32jsUUf7vluq/aRU5vDGSoMX5cVIhfAnqyESFrqpE77/PdFS4MhyyFQrv1X0YiNRWaSQ7XXueI7QUq9igK2AD3EcIDjicsbeY5Tdl4n1+hatk1ZShKhQAgA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, jbeulich@xxxxxxxx, roger.pau@xxxxxxxxxx
- Delivery-date: Fri, 13 Mar 2026 00:01:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12/03/2026 8:43 pm, Kevin Lampis wrote:
> diff --git a/xen/arch/x86/cpu/mcheck/mce_intel.c
> b/xen/arch/x86/cpu/mcheck/mce_intel.c
> index 839a0e5ba9..4d6b7d588e 100644
> --- a/xen/arch/x86/cpu/mcheck/mce_intel.c
> +++ b/xen/arch/x86/cpu/mcheck/mce_intel.c
> @@ -711,10 +711,7 @@ static bool mce_is_broadcast(struct cpuinfo_x86 *c)
> * DisplayFamily_DisplayModel encoding of 06H_EH and above,
> * a MCA signal is broadcast to all logical processors in the system
> */
> - if ( c->x86_vendor == X86_VENDOR_INTEL && c->x86 == 6 &&
> - c->x86_model >= 0xe )
> - return true;
> - return false;
> + return c->vendor == X86_VENDOR_INTEL && c->vfm >= INTEL_CORE_YONAH;
> }
This breaks P4.
It is not safe to write expressions like this, and I've already
explained why.
~Andrew
|
