[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] arm/ffa: deviate violation of MISRA C Rule 20.12
- To: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 13 Mar 2026 13:47:40 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=epam.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IAvZr++PS8HJGN2RBjUK5uwFOBMEtFwQQvyRsdE2Zos=; b=WCi1g8rFmMNSimdHmVvePuRsJ98jlXqncy3jrfrELknquqVS94ICAlnRfoDaS70SyG6KyztgEJ0imyL1sGLcTegdWV3XzCkjTM13irxaFnv9U8a1HfWjNXAgYF/6bbWg1Y9/RQqHa8rsNrG2TDm6Wn+4aiXdED7ACEdamRT2fKohLpiudQdAW5mOUzzLpstDPsJVqqWQQtjXflxLmcATrTb61hU0rHJQVLpBVfT7hFkKNOS84Cr/5qLVLODRdytgcdLFNDjqoDsZR25KpPjmP5mDbdK13NwOMmFSF5euN2YxZrd2qrq7WycIbKxQAX5IMMYPQ5dng6aIdMCFC3vb6Q==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IAvZr++PS8HJGN2RBjUK5uwFOBMEtFwQQvyRsdE2Zos=; b=ao8bn9hEuynwHiardN5Ud3dCQuTiTqp57DGEp4wA0pMV3gRyWFWNN8BhqP/2Dmx4ywkz4caveoqZWbG3jd4uzVWb9oImG42P9NMlfEyVBJMlyOPXiEqAi+6GS2HslzOjO2KMhtTl9hloqWcrPUdPvjDHpZy0q82M1Y438r67u9bSsJ4d4ifiRr+DXQ20+LZ8i2XLF1U22Htxz7blCLT8ezzfkinxJUHFDGIp5r8aZJkmW2JnBsw8oqMH+6H91OJBdaQmeTnlcGBEZQGzC5ahTPLe4YgbsnD2IzUSrpQo4WFJJLM5Z3+80whdYiVXIl2UFIjtm3FIqXj99lRdFj4lUQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=bkTpzgM5wyCkLQSlaZpXucJYI2alOu91TMxCZ/saGMuueqXxF2zD0O8POrVa+jUxmGIACC7rZbS41i3N3uDtnGqJ6wsczrXO+7lBm+biXxzEtGXnLF9qt7wWGxYFeZnEz6fIA3UvqzehUcPcbj6OjPFgfDJRpMPqHc+7gfD0KPJQkP+FcgycnwUXouqktXeFqc15GPTiynuMnNyH1TuzBhVJ6WpFnY2NuJoTEgtPjS5Fdnt74eMJU0gjA4QggwB3hEneIAxBWy+izYnSeR6jrhSUOiqnYcXRo/RP4ytkmzaehUhWFYEqpH9mzfPbZfy/z4MmV6AG67QmBUoo7KHSBQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=f8Dl5l9G3lrwSGow0v+1ueRpn/Gx91lb3+zz10Hj68OtDEskGiIz48cpSxpW88nLjyKZqp0RV6SfvH7jn1YdXK5WkDBdBHq7l/SldUcjxHLbdk6/nQWanWPh7wtYI1+nwTkNZtXT6yuLHX+HyWVZJBz46UcKKjm8sRpAG8Q3nnkf7/bhM7A4D8jvT2c9ZEmRxTpTEGsh1s8C7FPitZXp+ydG0MjEb5Bwb5Q6jQiNuIs9C/NiAZNiGehs/PVLEfSwiAKxC92c+FSudNjPb3gan7lcOlmavLDHTqFn2wtSP6yV+UL/d1Lw2uGvbA+lTUxCXSJF3+AhVsh+MUVBQZXevw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jens Wiklander <jens.wiklander@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- Delivery-date: Fri, 13 Mar 2026 13:49:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHcss5tR2+5DPx62k6x27kB0BQ6vbWsekIA
- Thread-topic: [PATCH] arm/ffa: deviate violation of MISRA C Rule 20.12
Hi Dmytro,
> On 13 Mar 2026, at 10:47, Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
> wrote:
>
> MISRA C Rule 20.12 states: "A macro parameter used as an operand to
> the # or ## operators, which is itself subject to further macro replacement,
> shall only be used as an operand to these operators".
>
> In this case the 'FFA_*' macros are used both as a regular macro argument and
> as an operand for '#' stringification in the expansion of 'FW_ABI()'.
> This is deviated using a SAF-x-safe comment.
>
> No functional changes.
>
> Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
Thanks for that :-)
Looks good to me.
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> Test CI pipeline:
> https://gitlab.com/xen-project/people/dimaprkp4k/xen/-/pipelines/2383141997
> ---
> xen/arch/arm/tee/ffa.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c
> index aa43ae2595..d4a77206c6 100644
> --- a/xen/arch/arm/tee/ffa.c
> +++ b/xen/arch/arm/tee/ffa.c
> @@ -80,6 +80,7 @@ struct ffa_fw_abi {
> const char *name;
> };
>
> +/* SAF-6-safe Rule 20.12 expansion of macro FFA_* with FW_ABI */
> #define FW_ABI(abi) {abi,#abi}
>
> /* List of ABI we use from the firmware */
> --
> 2.43.0
|
