[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] arm/ffa: deviate violation of MISRA C Rule 20.12


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
  • Date: Fri, 13 Mar 2026 09:47:38 +0000
  • Accept-language: en-US, uk-UA, ru-RU
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rUsdyvpnIikzo0pSsEdPSpYumfroyUemSD3sWoJp5xs=; b=scHxA4IWp0rNZUYlUsfJ3tMqrs7+b4kom0M4biJun98C0bXEEaJvsEosgq+2wGI6xvkshsHFKlX+SGNN22oYRQ2HandGC7L3HQ2N5PVvsa/XfhYnYF/FFJ9q4Xoxs/sN48pwh0P2Wkd4WNYGwpKZPo4MxOIAkmkgp6PxXDkA4gQdJDGOT+QPmRQaGWLsHm73VljvH9IG+ZJMTc4Tyf7C3GF0op9Ot3efdy2M/XsD/s2wALS57tGYC9QuJEy1sVoeK6+RuszoIuvnYH2agpUUsTeqKePNuUcQSRafY8qtseAL0l012KaGlLHWYn8WdIyU1+84m3QE28Xb2lnKx6mx/Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fGOP2Y+fkmCbdAx9mraAeL+xfFhd/20qODl79DRUZ4d8m4/fqmiRkhE2OfH3wjEv/uLVB0+9CoHKmWO+OfALzsNJuIs9Rler6pkGq4lpZYI5eznn1kn80ZRuJS+nshdtluDK6CUdFhNSv+5JgpviXeV+1eX2+8SbMprt5WNe1utSBQkLnbHUE//XVuV7WQXwHkEwJob8HBrvS4h9w4A/ZJmGFT8t3EsC1XiiIqkuFIrayaIexosE7YULVi8URc7PSM3uvwu0LEgxvywEDtPlE2L/whzmtO6g3AGgQODWRE4bg9lDOk+CXYEVIW9Fx31rPbPJ0ECuYJjlj1Ac+CfZZQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
  • Cc: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Jens Wiklander <jens.wiklander@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
  • Delivery-date: Fri, 13 Mar 2026 09:48:08 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHcss5tR2+5DPx62k6x27kB0BQ6vQ==
  • Thread-topic: [PATCH] arm/ffa: deviate violation of MISRA C Rule 20.12

MISRA C Rule 20.12 states: "A macro parameter used as an operand to
the # or ## operators, which is itself subject to further macro replacement,
shall only be used as an operand to these operators".

In this case the 'FFA_*' macros are used both as a regular macro argument and
as an operand for '#' stringification in the expansion of 'FW_ABI()'.
This is deviated using a SAF-x-safe comment.

No functional changes.

Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
---
Test CI pipeline:
https://gitlab.com/xen-project/people/dimaprkp4k/xen/-/pipelines/2383141997
---
 xen/arch/arm/tee/ffa.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c
index aa43ae2595..d4a77206c6 100644
--- a/xen/arch/arm/tee/ffa.c
+++ b/xen/arch/arm/tee/ffa.c
@@ -80,6 +80,7 @@ struct ffa_fw_abi {
     const char *name;
 };
 
+/* SAF-6-safe Rule 20.12 expansion of macro FFA_* with FW_ABI */
 #define FW_ABI(abi) {abi,#abi}
 
 /* List of ABI we use from the firmware */
-- 
2.43.0



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.