[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hvc/xen: Check console connection flag
- To: Jiri Slaby <jirislaby@xxxxxxxxxx>, Jason Andryuk <jason.andryuk@xxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 13 Mar 2026 10:44:06 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jlkCAird6sp2vbBjC8j0enw65qF8za2p7ncRhVr2gj4=; b=IgB53z+E86d4YQRb/BRnECf9/Wt/F7ujEsG33eXHQfq83j0JD/bgzJR/CrFV/BTrbEjPQ4GoHpzQWwbAe90LHqRcviAJ7nXJv/RaUjtGqOEKmj6BlvseJ2qm64q6pgB3EoHwIs12yKVScs0g0itT7gBBAtHHsMlnPvprEJk2mE0MbaLZbu3N4oOJ5ajLsnRBA9SX/AKIsl/ViTqxJxvqBCQ+CKveHI8EmGGu2COSyhl/WA5wLXAp8tZy2I1AbrOHUnCP0uCdjkqEhE5BBipPqNXcIrFulu1SPLcHQeKW7Y+u0Ax7QKNjSKFmV5YLjbWLPbd1ea9/X3kTW+XFSan9Og==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xcq9Z38JlzuZ5qw7AEMK018kujswaJL4eFK86JEV+lY3mdVFxGN/26kvjvWO7ajtit7WbMDRJWVTGFyXxU/1NJ5eWChJsHKbSpcG/gaffLlfPttG6JbFHpIPMPunF+fULcQIHn9oO3Z+XLvnU37NirFA39t/VY50//0f7JsgdJclCEhu2sDpfnzsRYW5S63kxIwIah3uTN+8hxP/WHjviWL1Vwi28BQvym90jSmYzOsuYxEB7ejXsjpLclZbxb4lDkfj/Q4mn9wbf3mx9RxjZbxx4RWuZTr5n30DpuObPGpBhDZSyHSC+77GdMweejoxrOz5SvpViWWnMTCERP5iDw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 13 Mar 2026 10:44:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13/03/2026 8:33 am, Jiri Slaby wrote:
> On 12. 03. 26, 18:38, Jason Andryuk wrote:
>> --- a/include/xen/interface/io/console.h
>> +++ b/include/xen/interface/io/console.h
>> @@ -19,6 +19,19 @@ struct xencons_interface {
>> char out[2048];
>> XENCONS_RING_IDX in_cons, in_prod;
>> XENCONS_RING_IDX out_cons, out_prod;
>> +/*
>> + * Flag values signaling from backend to frontend whether the
>> console is
>> + * connected. i.e. Whether it will be serviced and emptied.
>> + *
>> + * The flag starts as disconnected.
>> + */
>> +#define XENCONSOLE_DISCONNECTED 1
>> +/*
>> + * The flag is set to connected when the backend connects and the
>> console
>> + * will be serviced.
>> + */
>> +#define XENCONSOLE_CONNECTED 0
>
> This all should be an enum. And you can document it using kernel-doc
> properly then.
>
>> + uint8_t connection;
>
> And type check as well.
This is a non-Linux header file being re-sync'd with it's original source.
It describes an ABI between VMs, where things like enum are forbidden.
~Andrew
|
