[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] xen: rework deviation to address varargs MISRA violations
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Mon, 05 Jan 2026 17:14:22 +0100
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1767629662; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=IRShN447taDVIf8Z0vC2iX4D5SbpGvJAylpvDAXXMaU=; b=L1qPjv9dS+7SBCt7pcv7Ok7uOqznSkYuy57XUvyInoUZr2z6g1AbwS78kYNEMuI2fdd0 6a3MNHjTt2/HugJOBoXz/ky1DvRjTTVm7V04+yczmct22J3rrKfGXotvJTQq1K9A4UHEX 5TWMbuafVhwfy1WQE9qxNPodO2aZEaq+cyKcndFl/2URlAFTsqG41X99bA2/pbmsoIz/d k4YfasMQwafJh9NfYVZPiohBy5T/YrubKi254+LaLuXE3+U3OEKQZIdHqrQnnax/VBYRG dnGZ35E4hLO5sfqDgi+SskRCfcvFt8uqO4FqX5jSz1tkF9sr/zh6CdspuXtmJ2X28/7/g PZo4k0P5Z2JbRjDAC7wxPWCXbZr35179qPVPw6VtrExAdeMd9GwkKTw0FpKgxSb5bAYaE yFw5z4wNg1UvsipSAXin0kslBZsN3dynG47Df7r5vTkBB8G7zAPC7vN/+Zyjw7snuX3KO RCQtFiB8nbIydXTo8TwX53V3qAIPtcDXvs2raTEpym1zMo7U+EqvmqZbswMvH5u19K24U ElJj+QQkwR39/g38RsKrHPD0Afp9ZfF+pArqNNaTvsXztpcdSZkDDa39zJ+RkFlhHAj2/ QN5SnF2jcyJWIA+D3J3XBQh2tWZ/UnyjCg3dQ+gylzk3994lvf9rxTZkBxieB64=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1767629662; b=QXW0oDlusUnRnrE2n1yHvyxNBi3PklygDKM2BFWyX+wg8cRZH1SioBd0O2gCoGUSboNs HeDrDDO7lrkbfTZyQiXQ53i66tuNpM8XhRJ7OMqzr4b9Nt3BmLBVfXt3ZXTbnha+m50j9 bfyOOl0exnX5i6PV9xKGr3LgeELYrE5x/XEYQVfP3caqXcBt8+lVfRQnWWdJa8DQnz+xx S9G4J5MoD3m8zifTWCX42wF9/Uqv+7Vrs8T6AuG3YnklDNeW6AVBIudvGh6VdcmZ6bD2L +t2E9Pf87EQTY2uM+hmI0iJfBJ7NCmQ6NtkgueJ+w8FIWlNFna9oQRMmJNMz0nZ3zSj7W zHripiVfTjcoOFBLfbTUWbJS4xLfXZwOSkbh4Qee75h7UllFHbpMNd/ev1geRVEqvV67p jhom1tJneit5Jn0w7fxBE3w06ELFgLIfM418Vm/u22UdcG50HNUgdmUAgioo1LFbkIsdb sHlvAvyfRjhpMkgR9jLl4NvTZH9AvBh1RK2Q17LL6xnwaJ/pWpPvpGEkcVOZed5DEMHMD ynHitU7nePbBE/77VrZd1RsIf2BBsy2H99mKdG/rrkAV+f/nQfZ/CSUjgNM8yCLDBQOmk IPxWAKdYBT6TTKB4xRaxmJzpQaulhHxyiazVMFXLUohGuOExNCqHY56tn62WU74=
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, sstabellini@xxxxxxxxxx, consulting@xxxxxxxxxxx, Doug Goldstein <cardoe@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 05 Jan 2026 16:14:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2026-01-05 15:58, Andrew Cooper wrote:
On 05/01/2026 2:55 pm, Jan Beulich wrote:
On 31.12.2025 12:22, Nicola Vetrini wrote:
--- a/xen/common/libelf/libelf-private.h
+++ b/xen/common/libelf/libelf-private.h
@@ -84,7 +84,9 @@
#define elf_err(elf, fmt, args ... ) \
elf_call_log_callback(elf, 1, fmt , ## args );
-void elf_call_log_callback(struct elf_binary*, bool iserr, const
char *fmt,...);
+void
+__attribute__ ((format (printf, 3, 4)))
+elf_call_log_callback(struct elf_binary*, bool iserr, const char
*fmt, ...);
Just one tiny, nit-like request here: If already you touch this, can
the
missing blank ahead of the first * please also be added at this
occasion?
The parameter also needs a name. I have both fixed up locally.
~Andrew
Thanks
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
