[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] xen: rework deviation to address varargs MISRA violations
- To: Jan Beulich <jbeulich@xxxxxxxx>, Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 5 Jan 2026 14:58:04 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x3H64XTLbV7Q4tYtJ9M0Bb8wNfaPHGjyyFsHtSDBmlA=; b=jCeIVBXsGJIJp+T5dDl13Jt8khQUSUkLVMNQ/18YCfhDG3vtWrG9RKsqdbCB7h6XNGo/l8D/xpA2yBOECKLcYEIfkiB02UpD9b0enIfTbzWWtdW2SJimEVERlLir3Qmp+N4I9SCACaUaJxFJZSx+gHRV5lSCJc7Vli7ICU4rR7Jj43uCPejj3d4ezEZzFzx8mLu/RvrkUb6QYKk5mn8y4rBO3QaA6kDwjAn3A9EzASWTpYrWzqkOYL88dgXRB1yvJhZrcmLbqChpLJW5MZKbIkABxO9Y9YGsL119HMXclB/fBkAKeWNPChLy0aJpiTwVMUaGm6bja3uhORLFLeNuUA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=N81HSWSklfr0s+HkvPFwEE0C1nBlG/tajm7WeDIb6smySEH0G4nEy5pnWpbQBXfl2zspQpmGFj0+dN7yg/08NZxvCjtIm8+T3SLMZ9Ia7oeeGSQJf1HTDHravAw1Sk/Ggk99Qk8srUf80ZnnhvC8DZtZe4M7EUpL0O+PZj0Spotv1izQEcuJnAV1zg+rRneoyrhsFxdKgoPJ2P2ADQ4Sh6JNqa/j/4Zq83F1tEUIOUfapWfRhOmoV5qUso+ZwanD3i4F7JTv8UlzqmLXb7pc7WzDuNLWmp4TgYiAfL0EzvfCH7wvHoNJ+6s9g4Fw5P5wM5CU6HRE7HiHoBzhZLA3Mw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, sstabellini@xxxxxxxxxx, consulting@xxxxxxxxxxx, Doug Goldstein <cardoe@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 05 Jan 2026 14:58:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05/01/2026 2:55 pm, Jan Beulich wrote:
> On 31.12.2025 12:22, Nicola Vetrini wrote:
>> --- a/xen/common/libelf/libelf-private.h
>> +++ b/xen/common/libelf/libelf-private.h
>> @@ -84,7 +84,9 @@
>> #define elf_err(elf, fmt, args ... ) \
>> elf_call_log_callback(elf, 1, fmt , ## args );
>>
>> -void elf_call_log_callback(struct elf_binary*, bool iserr, const char
>> *fmt,...);
>> +void
>> +__attribute__ ((format (printf, 3, 4)))
>> +elf_call_log_callback(struct elf_binary*, bool iserr, const char *fmt, ...);
> Just one tiny, nit-like request here: If already you touch this, can the
> missing blank ahead of the first * please also be added at this occasion?
The parameter also needs a name. I have both fixed up locally.
~Andrew
|
