[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 02/14] xen/riscv: add <asm/asm.h> header
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Mon, 23 Jan 2023 11:10:48 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rM9DSQIxYciNDglaL20GVtHT0dRWq85YIEIHFnb+y8g=; b=IOu+5iBa8vlxUXDGzh/Js1VscgZm9t/aCoZMbtqX5h+n48qrp3MdT1m6JhIJAA3q9cKIrZimEmlymAhegBTn3defgDwcSutQQhmQNezjL3tgsEVkEQmhWJ2Rd6RCtgLKN9s7F6/ksJqNGsFvHICVGvdEayP1l2zFUfazfteS6+POePheepAXdsji8WvPAX5yXVuYNEfjtX/snORz3XFMUs2c1OPW0eMrmnT0N/UYna8bB4j7Dkrr4m91O9oIdT5x7ej9aOX3zMg4obD6pa28ci6wSd3rlEbJu4lyBkzQ5nX1Xsl8RK18/hyQppUf4F/O6GdxnYHi7Ztdw1UmtCQHnA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cq57Wn54lLisFpVOg5WyiBQ3lSJdpWJJLD0ROwypjQrtF4BJF4uQWNVNhfXqxjhEhMAUOqGNK6Hr8G1SADGflQRn3adVNPUjiDBTUoU0yoax7ssbo2IPKjdKAHsRnAeD68ibC1jZeI2uxox0QWGsQS6t6/WMgOgBFrsANdKDWF7IGTYfnXl4CcYmV9NN+sHaTT4udsyTZi4CmNiW0ppGGsm4UaHVtYAU9VfYlOHDqxjrKAGswbuGQejNaRjaBsXJJ0UH/UVqX4KK2dUq/OfXhHz6f+V7tzRVo45ev73VJJfz2AkL/69BdA0S+lSfW+8b2gCwvNpPR7sTGbJ8WHSC+w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 23 Jan 2023 11:11:02 +0000
- Ironport-data: A9a23:eU3Wia9KY/SLI8/u9rcWDrUDNX+TJUtcMsCJ2f8bNWPcYEJGY0x3n WAfUWCObvfeZzSjKtpyPYq+9hsCu5bdn9VgSAFqqiE8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKucYHsZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIw1BjOkGlA5AdmPKoQ5Aa2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDkl// vUyCzkiUCu+pKGG/+6qDbNhmdYKeZyD0IM34hmMzBn/JNN/G9XvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWCilUuidABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTCdhMRePjrKUCbFu7mkETJQ8bakeBneCmgWuDBf5Zd HIm9X97xUQ13AnxJjXnZDW6qnOZuh8XW/JLDvY3rgqKz8L8+B2FD2IJSjpAbt0Ot8IsQzEuk FiTkLvBCj1mtrmIQnu17LaKqiizPyNTJmgHDQcOSgEP8tT4oIU+ixvJZtlmGa+xyNbyHFnYy jSLtzQ3hq9Vg9QC0a665njYjznqrZ/MJiY+4QPRWWCp5x14f6aqYoWp7R7Q6vMoBIGdQ1qav XlCmNWE6+sODpalmymEQeFLF7asj96VPTuZjVNxEp0J8zW252XlbY1W+Ct5JkpiLoADYzCBX aPIkQZY5ZsWMH70a6ZyOti1E55zkvGmEsn5XPfJaNYIeoJ2aAKM4CBpYwiXwnzpl08v16o4P P93bPqRMJrTMow/pBLeegvX+eVDKvwWrY8Lea3G8g==
- Ironport-hdrordr: A9a23:CJ+4tq+3it9Q7nLMYuRuk+DZI+orL9Y04lQ7vn2ZKCY1TiX8ra vFoB11726WtN98YhwdcLO7VpVoI0mxyXcd2+B4AV7IZmbbUQWTTL2L4ePZsl/d8yCXzJ876U 9rG5IObeEZAjBB/KLH3DU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZLN/mQOdIReGXikafzlTdFxmXvK6nbsiAgARrVYCAAALRAA==
- Thread-topic: [PATCH v1 02/14] xen/riscv: add <asm/asm.h> header
On 23/01/2023 11:00 am, Jan Beulich wrote:
> On 20.01.2023 16:31, Andrew Cooper wrote:
>> On 20/01/2023 2:59 pm, Oleksii Kurochko wrote:
>>> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
>> There's some stuff in here which is not RISCV-specific. We really want
>> to dedup with the other architectures and move into common.
> I have to admit that I'm not fully convinced in this case: What an arch
> may or may not need in support of its assembly code may heavily vary. It
> would need to be very generic thing which could be moved out. Then again
> xen/asm.h feels like slightly odd a name with, as kind of already implied
> above, assembly code being at times very specific to an architecture
> (including e.g. formatting constraints or whether labels are to be
> followed by colons).
Half of this header file is re-inventing generic concepts that we
already spell differently in the Xen codebase.
It is the difference between bolting something on the side, and
integrating the code properly.
~Andrew
|
