[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 02/14] xen/riscv: add <asm/asm.h> header
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 23 Jan 2023 12:00:41 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4ZYWa4RhsCkfQRLtp+DAQup+Zia8TMo5i5Y2bh0Yl3Q=; b=Sws9cXrnz6ucmGqSuw/Lq7dB+L4UixjjZw1RxSZXzRXRLrnQEt8z7UBnYwNvdLWowBnT78wSk0+0l7U3VPZg2hohWbbm+tAflq2lDgac3vp2GQrV2XkutvDBwtTLPJUauDrid7n7qLGQElCLfIq+HG7r/8UVA5ERFoOvfNgkpzaDSosGN8MVKrbfB7yACD3+7yMDjyVpfBxJ3yxbvOCPoyZU1QJrTGAgI0XXUOCQvoLB8Nx6iZNAr2Ifg/qCNowBMcgPD2L2pJJljSBcxPL9WQkGtu0pnGlYPkEWHKi0mGWKf2Z6lEzMpJx271q2wVkTDKCi9AbYRpngENKkcShEuA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GQ0jl+d5ztb4sjCjGEYxwAZRbYFE3ji9hsLD/JAs7ciNB90Ew38tCjShPy55HI0b0eIvcnvxNG8GaT980ZbqdBH4W/uYsoQzjAbTKg2NHCRDoQ10RfJUAr5b8xm3q2WHL+OrCrxUSg16sbr3P0a23+PMHrP5X21waAG/oieAqUPWcA94JzqFwZTlwBGyZBK2LwVmD4mHwqNFqu1L9socc3QmRjrSDvCurgV9KRtL0QkVfPx/xbJuFgUDtpPV+5UoRz+/14CgIrSLavTkdZW5dx67TUbpVpyjT8OLWw8dUfDxaC67A7SyZYyvlQr3V4li9dK2aycLTvU+iJYKlKQ7bQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 23 Jan 2023 11:01:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20.01.2023 16:31, Andrew Cooper wrote:
> On 20/01/2023 2:59 pm, Oleksii Kurochko wrote:
>> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
>
> There's some stuff in here which is not RISCV-specific. We really want
> to dedup with the other architectures and move into common.
I have to admit that I'm not fully convinced in this case: What an arch
may or may not need in support of its assembly code may heavily vary. It
would need to be very generic thing which could be moved out. Then again
xen/asm.h feels like slightly odd a name with, as kind of already implied
above, assembly code being at times very specific to an architecture
(including e.g. formatting constraints or whether labels are to be
followed by colons).
Jan
|
