[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/11] x86/shadow: move bogus HVM checks in sh_pagetable_dying()
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Fri, 6 Jan 2023 01:00:44 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7R5caMStUTAOv6xs/IolzeChzCMqWnsnP5dG+yqWnRY=; b=dI8Xo5bm2EGFKGt8yPfsMMJB/UGEjOCOzNGwSnMYyPORa4zyqFFHz3T0sJnWbAGjx0xGaYgc93OMxZx1ehg4k089ZlZz0NJ2kYESvIvIEZP8Eiode7FEz7YNWBaxveE5ZdhA8a66BBW8egJxjUTaW9t9Ui2XWgPMLDFmGx2c9tsc7wiMrc/MdHtNquamLnETG+UKFcwMtSZ6c2NkPApgsJjnLDJOVKpqSq4x+CCCj9B9NTOGujLzF0ef5u8XV5vrmxzt8ec0SdI6G40k2GOP/V7iCqodNpvK9DsesbsR6bTdKcuNAlSZTKbuDUJbcUBbSMJbie5KwSL1hDmACzIodg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KGzl9qiPkUbUV4gsp02fCM4xZS9Nlqw88rI49597S3lBd3Lg5EK1fzu3YegUHa/8gJktu5lO2bksRCl6tm3LZc3sxGqnBSSE+vqQbliu9qLHsh54zFodQjNLrYNSssbD9D7qSynm4kp+2z3wD4ShChwjEPjZuR+e4BlE6z2G6JQsGHH+tWA4wBMCVJGM/UGfzGVvLG5iRRMArkUXseHCN7c1XTcFs9HcBBe7bSMlgV/uxx9NJ/pz5DBXScMpPOSMXGqDf5c2amE/K8RFzDuoULEdHOjbwJ09Jx3GQDQ02HbWgtFFtLi7eCqmP/kV2mnGn2VZxaamQa8gJ6x3OANNfg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "Tim (Xen.org)" <tim@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>
- Delivery-date: Fri, 06 Jan 2023 01:00:57 +0000
- Ironport-data: A9a23:ze01W66kd+ezYDiZXq7GbQxRtAnGchMFZxGqfqrLsTDasY5as4F+v mYeCDuGPauNYjPyft1xPtmw/RhTscOGyoBlQQo+rS00Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZlPakT4QeF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mz s0xBz4XVTC6vM2x/LTiVcZBqc4JBZy+VG8fkikIITDxK98DGMiGaYOVoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6MlEooiOSF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNLSOHhp6c16LGV7m8iBgRIBXz8m77nq3KGY89bB kgQ+QN7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq16bO8vT60fy8PIgcqeS4BZRsI5Z/kuo5bs/7UZtNqEarwhNuqHzj1m miOtHJn3+lVitMX3aKm+1yBmyirupXCUg8y4EPQQ36h6QR6IoWiYuRE9GTm0BqJF67BJnHpg ZTOs5H2ADwmZX1VqBGwfQ==
- Ironport-hdrordr: A9a23:WkNGP6s3DjLwdJm1/91fD+sa7skDgNV00zEX/kB9WHVpm6yj+v xGUs566faUskd2ZJhEo7q90ca7Lk80maQa3WBVB8bBYOCEghrOEGgB1/qA/9SIIUSXmtK1l5 0QFpSWYOeaMbEQt7ef3ODXKbcdKNnsytHWuQ/dpU0dMz2DvctbnnZE4gXwKDwHeOFfb6BJba Z1fqB81kedkXJ8VLXCOlA1G9Ltivfsj5zcbRsPF3ccmXWzZWPB0s+AL/CAtC1uKQ9y/Q==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZIR9eJqf2NVsSC0qgmrUFbi0j7K6QklwA
- Thread-topic: [PATCH 05/11] x86/shadow: move bogus HVM checks in sh_pagetable_dying()
On 05/01/2023 4:04 pm, Jan Beulich wrote:
> Perhaps these should have been dropped right in 2fb2dee1ac62 ("x86/mm:
> pagetable_dying() is HVM-only"). Convert both to assertions, noting that
> in particular the one in the 3-level variant of the function comes too
"came too late"?
It doesn't any more with this change in place.
> late anyway - first thing there we access the HVM part of a union.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
