[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/11] x86/shadow: move bogus HVM checks in sh_pagetable_dying()
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 9 Jan 2023 09:39:53 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O/vQoGlSzAJMqyZU02m9lIFhjHp/l09qgQro552DAa8=; b=ir2WkemBCq/kbWjgkvntvhYJGrNxIhNKt+qMmwXJQ/RZVuedNiYtFUUbxa+9IDDrKBgbJSZ3y508nBhL/RD+h7/3KPo9dyZveG0JqvazRxC6ks1ZW2PceT1aeDi6BKtjYMx/nFcSQYUMYtzZypF51F8s3KIekbmGOVnyxViyS5/FGbuG6kT8BNcZIjdUOZthXttdulhho1lzeJN1SP3LB4Mi8J0zK6K7dHpUIz8zXdvVmPJoR31xJRaAmn5ZQWBODVhlWgU1uEEVtdtntmqG5hKK1dyeQPeecwg87Vwak/C+5yiyHd/IdYvqB3y8EcuLdOiWuFYiJ1pdWizuqQ6p5w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OFssc1o728s/XI9pI/909eCPUbOjqfhLyRNGxBl9NEDRVlnu9TFc0rXgHeAv7P82t6u5lf0qfbwFPZrvng87iNHTXzkasl+p4Akag2J5V2ahLzKuQ2ZkeFSjvk/TTzIsnQJZ4/suR4lqHM0fLueP6JlMmZQmEt2f9tdp3kycDMPtf6lhUNeN7Sw4DG6Q5PXxR98thKIQYKW9UYJ7m0Bwqv7sNE/QcbvwEWIhzymr1jmtARs9Q3Gwuliz91O6ycigX3CPwVbVRG4NRVWkrYLgifqFrOy6Cx6d4HWGwmmivpP9bpfEO8sAx0KE8urPnJnKJcW72wAO+hnXsXnCxCUrFA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "Tim (Xen.org)" <tim@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 09 Jan 2023 08:39:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.01.2023 02:00, Andrew Cooper wrote:
> On 05/01/2023 4:04 pm, Jan Beulich wrote:
>> Perhaps these should have been dropped right in 2fb2dee1ac62 ("x86/mm:
>> pagetable_dying() is HVM-only"). Convert both to assertions, noting that
>> in particular the one in the 3-level variant of the function comes too
>
> "came too late"?
>
> It doesn't any more with this change in place.
Fine with me either way, so I've changed it. Iirc in particular George has
been advocating for writing descriptions in present tense, even if in the
course of a change the stated fact changes as well.
>> late anyway - first thing there we access the HVM part of a union.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Thanks.
Jan
|
