[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/11] x86/shadow: replace sh_reset_l3_up_pointers()
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Fri, 6 Jan 2023 00:55:09 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NuV4HaD2bCln0Nm0zAO4yk9D+7lRmMaC1YSTGaUxamE=; b=fkt7Jmhe8FBzQHojwck8pTwVl+k5EmauAVr7a2Z6Efz0sP77L/m2dmHxd7xafYzRxm7xkgRDHuN25DayPQVMnFTfqezc4PytcJfqC/LbU0ScTQr6HpQGcj8oUziifFXq9lClx5l/c/zAhaFNaAhzZNXzCgEjBPFMVUhjN54RGdKFwk++Ev2QE4EtBNc2AorN3TTUJP4ofIJ1nM7BUGlVQFEpPpxoAW239HWAiOXMDFnRR9++4bsU30nyXyAVS12AX6mifmaLR+EkdRmb34hugJ+IIz3yap/tkiFsdLCFgcJqVB/IxOUDbnMVPpf4LfB1grpKtL3juy9Lw1b4xNYXlg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I7zJ96J4bufKwqxWhQmZFMYqEgbXCZjVxGzVwGpoNdNWIWmcHeT9id8UoLiY4SOdSowwaeSJ+C0A7OJ9b7ifO4hK/SXAhU0otJQoH5VY41p1xdRMsRgZujw2EBFJeqeKiI3tog6tY6Q9qvPuAe+uVU0sb62B3XPW40vQOFv6Oi1vw0nrmWn5CWAx4ZYDJlqg9SeC5Y4mePGxhmAa+qIyk+99p+fsau/A0Qpaim4VeY1O6u14ct++LwnQqHdsU/7luk8T24+vk/Wo9F07z2S3+lCInIB5GDzuPRw1ZD+EDnqfLoqc6+XK7UdrsArwBfvvwj4C2BqE/v/OizsR+5y7mQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "Tim (Xen.org)" <tim@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>
- Delivery-date: Fri, 06 Jan 2023 00:55:41 +0000
- Ironport-data: A9a23:WpQ7/aj+dSw5rgEWgAUF9+fNX161VhEKZh0ujC45NGQN5FlHY01je htvDDyBMq2DZ2b9LYoia9nnpB4D7Z+DyIRqTgJl+XtmEysb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6sT5QeDzyJ94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQBcA4AcwytrNuo5+68cdtuqdwSNenkadZ3VnFIlVk1DN4AaLWbH+DmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilMqluS0WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapDTO3oq6Mw0TV/wEQ9Gh0na0K0isX6ixeRVtxtF 0ZP2WkH+P1aGEuDC4OVsweDiHyOswMYWtFQO/Yn8wzLwa3Riy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU3313qiQhSO/P24SN2BqTTMFSCMV7t+lp5s85i8jVf5mGa+xy9HwRzf5x mjWqDBk3+lKy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1 EXoUeDHhAzSJflhTBCwfdg=
- Ironport-hdrordr: A9a23:ko1WGK4XRbuPRHTvmQPXwAzXdLJyesId70hD6qkQc3Fom62j5q WTdZEgvyMc5wx/ZJhNo7690cq7MBHhHPxOgbX5VI3KNGXbUQOTR72KhrGSoAEIdReeygZcv5 0QCZSXCrfLfCVHZRCR2njFLz4iquP3j5xBnY3lvhNQpZkBUdAZ0+9+YDzrdXFedU19KrcSMo GT3cZDryrIQwVtUizqbkN1OdQqvrfw5evbXSI=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZIR6u/vHw4RYb/kGm/un2td4VGq6QkM0A
- Thread-topic: [PATCH 01/11] x86/shadow: replace sh_reset_l3_up_pointers()
On 05/01/2023 3:59 pm, Jan Beulich wrote:
> Rather than doing a separate hash walk (and then even using the vCPU
> variant, which is to go away), do the up-pointer-clearing right in
> sh_unpin(), as an alternative to the (now further limited) enlisting on
> a "free floating" list fragment. This utilizes the fact that such list
> fragments are traversed only for multi-page shadows (in shadow_free()).
> Furthermore sh_terminate_list() is a safe guard only anyway, which isn't
> in use in the common case (it actually does anything only for BIGMEM
> configurations).
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
I think. The reasoning seems plausible, but it would probably benefit
from someone else double checking.
|
