[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] console/serial: set the default transmit buffer size in Kconfig
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 23 Jun 2022 15:30:19 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xBo1s2Eo42rC4sM9OoapxCB7WufBem5PlY3JzRIYNus=; b=AebgbeyT4uQ+KInzWHypK+Xb5ZPuwUCNYk5llY+S5MMXMjNVQmfCIM28TIE9H98OKAHoafHmTZ1Vs5RiMrDw81OhuzfXWIyP9k++JRKrAKCizske1eZQwRMg64DP4jtN0AbnLO2lGVQ2JRAMudSEfaqgtok3dtiAeSI9C7v0eqOg/ERy7+fUfZ//M3v59PdOWnE8SPr/fKYrR+L4UbRPLWvz4pk7bGZDf+8kxZ/VNU38KBnce5vaKxMz3lUGdh9SjU2lcpP4+rzBroqRMtMMsHXKuLiJDv3KrF9GOQha1v4wao2EOntxkB3ecnLKSZMEQbgIIq54MFG6nJz5OzYgVA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nLMXNbq8pFD4gus1B5irw1ueASK/fRBe+k+8u3NJxGOD3A7/8rBHr5wzrob6U5/cHD9JrGJwQp27Pbq8mgqHvKNlGtNdlzQaxK0Tcqyy8wrbfeYrp3hDz9Ed2iFHe/HiZ4XWne6Rka0s2fPWE33haMRmofwN30hHOUx7Qw8Hc2CzNlgxXqWIxOIjgjJJT60RAUbkgx6eAdn2VloI1bPGNTRey20+iDaZXsOKPhC6Lcjs5/+Hsq32w1x2aBZRQuDoXOpblYaNzvfZCHjrvVqvRbsJwkNjMPpCiVwgD2vdSfTGwrRLsaMuzI/pu6JfJ7Qb5k94hhv7aRrlQPSnbvbgJA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 23 Jun 2022 13:30:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.06.2022 11:08, Roger Pau Monne wrote:
> --- a/xen/drivers/char/Kconfig
> +++ b/xen/drivers/char/Kconfig
> @@ -74,3 +74,13 @@ config HAS_EHCI
> help
> This selects the USB based EHCI debug port to be used as a UART. If
> you have an x86 based system with USB, say Y.
> +
> +config SERIAL_TX_BUFSIZE
> + int "Size of the transmit serial buffer"
> + default 16384
> + help
> + Controls the default size of the transmit buffer (in bytes) used by
> + the serial driver. Note the value provided will be rounder up to
> + PAGE_SIZE.
I first wanted to point out the spelling mistake (rounded), but I
wonder what good that rounding does and whether this description
isn't really misleading: serial_async_transmit() rounds down to a
power of two. So likely the value here would better be a log-2
one.
> + Default value is 16384 (16KB).
Perhaps (16kiB) (albeit the default value would change anyway if
the above is followed)?
Jan
|
