[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/2] console/serial: set the default transmit buffer size in Kconfig


  • To: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • Date: Thu, 23 Jun 2022 11:08:51 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hH75V/WM2LVZxnBqVh030EFKsJy+Y/Gn6Q/hZLew5iQ=; b=Mp9Yor0QmzLrnUM8GAJLS6+NjewK9qxdw+LaZUKU/HP0eyFNDAazT0TbnHHorBdWB8rqDr/wDkiiAEUsXXjHBnAosDQfwAVDwtm+c/AecA3UMPJzqakh7f2j81qySPY5K3Cp4k5oh6TGI+Ce8fTg2111mRD8jv8pgk5WmuRaJ4pB1b5VgP1Vx2SHwdRIRg1zWpu96E8igXKvLuwhRQcUZGBElKc8MjildQ4kIYlRITOsZ9UH4rUxtx5pOmYSFlMnJLdwED1Ax9b63I+DtWFfu9hT9wtSnSgyMo8g9H0pRAnBUJ1ezm0QeeMpS2FbZJAOOqSP2gSqR3L+erDy3qyw2w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jxNREDdB0xe/kGVku9qpnfEpDJPSPRrwFTUw5vncVHWX/0jTxJnD4q+tdWOVJD3efmacbSRTICjWs/1ub27albqJnO9IjLKWdfc/uEMhg0VCAw6BASDzkF0yL3xUSmelbg3TcBiNT8EdsZyAlxV+PuQ5ODcqiTGnY1Ce4MIYCoKnUxHQfui72yaYK6jNp+hI2f583LSv+7ro3CxfFeF494qPdIvfXgGhDfvFEjGxhuXyW8kOEiuHe1Ack4SoA+Gbgy3XLdtn+zO5jtHUf8RBAgShyo4BK5XP/bQmDaqQNCeAXgpO1888si1CGHQPvXgmC+0O/GzRKGcjm/i2756BHA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Thu, 23 Jun 2022 09:09:13 +0000
  • Ironport-data: A9a23:k1A9B6q035Dpbca6koab8tG/QgVeBmIFZBIvgKrLsJaIsI4StFCzt garIBnUO/2MM2Hyct0nPo/k8EgCusXcxt8xSFZprCw2E3sU9JuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrRRbrJA24DjWVvT4 4mq/6UzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBAqKSssA9YzRhNApZZZ9pw5+eBSSRiJnGp6HGWyOEL/RGKmgTZNdd39ktRGZE+ LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkGgnFs2aiiHt6HD yYdQSBoYxnaJQVGJ38cCY4knffujX76G9FdgA3O+PptszGDpOB3+L/jacvMK5/bf5RQnE21j TL++HumWChPYbRzzhLAqBpAnNTnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM/pdI UEJ/islrYAp6VemCNL6WnWQomOAvxMac8pdFas98g7l4rHP/w+TC2wATzhAQN8rrsk7QXotz FDht8ztLSxitvuSU331y1uPhTa7OCxQKHBYYyYBFFEB+4O7/N51iQ/TRNF+FqLzlsfyBTz73 zGNqm45mqkXiskIka68+Dgrng6Rm3QAdSZtji2/Y45vxloRiFKND2Bw1WXm0A==
  • Ironport-hdrordr: A9a23:4LOPS6vKm1Kpp1cBctfmBGt/7skC5IMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBHhHPlOkPMs1NaZLXLbUQ6TQL2KgrGSpwEIdxefygcZ79 YYT0EcMqyOMbEFt7ec3ODQKb9Jrri6GeKT9J/jJh9WPH1XgspbnmJE42igYy5LrF4sP+tFKH PQ3LsPmxOQPVAsKuirDHgMWObO4/XNiZLdeBYDQzoq8hOHgz+E4KPzV0Hw5GZUbxp/hZMZtU TVmQ3w4auu99m91x/nzmfWq7BbgsHoxNdvDNGFzuIVNjLvoAC1Y5kJYczLgBkF5MWUrHo6mt jFpBkte+x19nPqZ2mw5SDg3gHxuQxen0PK+Bu9uz/OsMb5TDU1B45qnoRCaCbU7EImoZVVzL 9L93jxjesZMTrw2ADGo/TYXRBjkUS55VA4l/QIsnBZWYwCLJdMsI0k+l9PGptoJlO31GkeKp guMCjg3ocXTbvDBEqp/VWHgebcE0jbJy32DHTr4aeuonprdHMQ9Tps+CVQpAZEyHsHceg02w 31CNUXqFhwdL5nUUsEPpZmfSKWMB27ffueChPlHbzYfJt3SE7lmtrQ3Igfwt2MVdgh8KYS8a 6xIm+w81RCMX7TNQ==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Take the opportunity to convert the variable to read-only after init.

No functional change intended.

Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
 xen/drivers/char/Kconfig  | 10 ++++++++++
 xen/drivers/char/serial.c |  3 ++-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig
index e5f7b1d8eb..a349d55f18 100644
--- a/xen/drivers/char/Kconfig
+++ b/xen/drivers/char/Kconfig
@@ -74,3 +74,13 @@ config HAS_EHCI
        help
          This selects the USB based EHCI debug port to be used as a UART. If
          you have an x86 based system with USB, say Y.
+
+config SERIAL_TX_BUFSIZE
+       int "Size of the transmit serial buffer"
+       default 16384
+       help
+         Controls the default size of the transmit buffer (in bytes) used by
+         the serial driver.  Note the value provided will be rounder up to
+         PAGE_SIZE.
+
+         Default value is 16384 (16KB).
diff --git a/xen/drivers/char/serial.c b/xen/drivers/char/serial.c
index 5ecba0af33..8d375a41e3 100644
--- a/xen/drivers/char/serial.c
+++ b/xen/drivers/char/serial.c
@@ -16,7 +16,8 @@
 /* Never drop characters, even if the async transmit buffer fills. */
 /* #define SERIAL_NEVER_DROP_CHARS 1 */
 
-unsigned int __read_mostly serial_txbufsz = 16384;
+unsigned int __ro_after_init serial_txbufsz = ROUNDUP(CONFIG_SERIAL_TX_BUFSIZE,
+                                                      PAGE_SIZE);
 size_param("serial_tx_buffer", serial_txbufsz);
 
 #define mask_serial_rxbuf_idx(_i) ((_i)&(serial_rxbufsz-1))
-- 
2.36.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.